From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJjkb-00031r-J8 for qemu-devel@nongnu.org; Tue, 28 Nov 2017 12:32:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJjkW-0001rJ-7D for qemu-devel@nongnu.org; Tue, 28 Nov 2017 12:32:53 -0500 From: Laurent Vivier Date: Tue, 28 Nov 2017 18:32:24 +0100 Message-Id: <20171128173224.1138-1-lvivier@redhat.com> Subject: [Qemu-devel] [PATCH] pseries: fix TCG migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, David Gibson , Bharata B Rao , Daniel Henrique Barboza , Laurent Vivier Migration of pseries is broken with TCG because QEMU tries to restore KVM MMU state unconditionally. The result is a SIGSEGV in kvm_vm_ioctl(): at qemu/accel/kvm/kvm-all.c:2032 radix=, gtse=, proc_tbl=) at qemu/target/ppc/kvm.c:396 version_id=) at /home/lvivier/qemu/hw/ppc/spapr.c:1578 vmsd=0x1009479e0 , opaque=0x1019103c0, version_id=) at /home/lvivier/qemu/migration/vmstate.c:165 at qemu/migration/savevm.c:748 This patch fixes the problem by not calling the KVM function with the TCG mode. Fixes: d39c90f5f3 ("spapr: Fix migration of Radix guests") Signed-off-by: Laurent Vivier --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 9efddeaee5..a471de6cab 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1570,7 +1570,7 @@ static int spapr_post_load(void *opaque, int version_id) err = spapr_rtc_import_offset(&spapr->rtc, spapr->rtc_offset); } - if (spapr->patb_entry) { + if (kvm_enabled() && spapr->patb_entry) { PowerPCCPU *cpu = POWERPC_CPU(first_cpu); bool radix = !!(spapr->patb_entry & PATBE1_GR); bool gtse = !!(cpu->env.spr[SPR_LPCR] & LPCR_GTSE); -- 2.13.6