From: David Hildenbrand <david@redhat.com>
To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Alexander Graf <agraf@suse.de>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v1 for-2.12 09/15] s390x/tcg: use program_interrupt_ra() in SCLP Service Call
Date: Tue, 28 Nov 2017 21:33:19 +0100 [thread overview]
Message-ID: <20171128203326.6062-10-david@redhat.com> (raw)
In-Reply-To: <20171128203326.6062-1-david@redhat.com>
Now we can drop potential_page_fault().
Signed-off-by: David Hildenbrand <david@redhat.com>
---
target/s390x/misc_helper.c | 3 +--
target/s390x/translate.c | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index e50ea480be..3c2b589f7b 100644
--- a/target/s390x/misc_helper.c
+++ b/target/s390x/misc_helper.c
@@ -63,8 +63,7 @@ uint32_t HELPER(servc)(CPUS390XState *env, uint64_t r1, uint64_t r2)
qemu_mutex_lock_iothread();
int r = sclp_service_call(env, r1, r2);
if (r < 0) {
- program_interrupt(env, -r, 4);
- r = 0;
+ program_interrupt_ra(env, -r, 4, GETPC());
}
qemu_mutex_unlock_iothread();
return r;
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index d0859c4bc7..76b222b0ce 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -3704,7 +3704,6 @@ static ExitStatus op_sqxb(DisasContext *s, DisasOps *o)
static ExitStatus op_servc(DisasContext *s, DisasOps *o)
{
check_privileged(s);
- potential_page_fault(s);
gen_helper_servc(cc_op, cpu_env, o->in2, o->in1);
set_cc_static(s);
return NO_EXIT;
--
2.14.3
next prev parent reply other threads:[~2017-11-28 20:33 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 20:33 [Qemu-devel] [PATCH v1 for-2.12 00/15] s390x/tcg: cleanup and fix program interrupts David Hildenbrand
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 01/15] s390x/tcg: introduce and use program_interrupt_ra() David Hildenbrand
2017-11-29 14:55 ` Cornelia Huck
2017-11-29 15:13 ` David Hildenbrand
2017-11-29 17:16 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 02/15] s390x/tcg: get rid of runtime_exception() David Hildenbrand
2017-11-29 17:17 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 03/15] s390x/tcg: rip out dead tpi code David Hildenbrand
2017-11-29 3:10 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2017-11-29 17:28 ` [Qemu-devel] " Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions David Hildenbrand
2017-11-29 15:13 ` Cornelia Huck
2017-11-29 15:14 ` David Hildenbrand
2017-11-29 15:35 ` Cornelia Huck
2017-11-29 15:38 ` David Hildenbrand
2017-11-29 15:39 ` Cornelia Huck
2017-11-29 15:45 ` David Hildenbrand
2017-11-29 15:57 ` Cornelia Huck
2017-11-29 16:05 ` David Hildenbrand
2017-11-29 17:35 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 05/15] s390x/pci: pass the retaddr to all PCI instructions David Hildenbrand
2017-11-29 17:37 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 06/15] s390x/diag: pass the retaddr into handle_diag_308() David Hildenbrand
2017-11-29 17:38 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 07/15] s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG) David Hildenbrand
2017-11-29 15:50 ` Cornelia Huck
2017-11-29 15:54 ` David Hildenbrand
2017-11-29 15:59 ` Cornelia Huck
2017-11-29 16:25 ` David Hildenbrand
2017-11-29 17:52 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 08/15] s390x/tcg: io instructions don't need potential_page_fault() David Hildenbrand
2017-11-29 17:53 ` Richard Henderson
2017-11-28 20:33 ` David Hildenbrand [this message]
2017-11-29 18:10 ` [Qemu-devel] [PATCH v1 for-2.12 09/15] s390x/tcg: use program_interrupt_ra() in SCLP Service Call Richard Henderson
2017-11-29 19:01 ` David Hildenbrand
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 10/15] s390x/tcg: use program_interrupt_ra() in DIAG David Hildenbrand
2017-11-29 18:11 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 11/15] s390x/tcg: use program_interrupt_ra() in per_check_exception() David Hildenbrand
2017-11-29 18:13 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 12/15] s390x/tcg: use program_interrupt_ra() in SACF David Hildenbrand
2017-11-29 18:13 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 13/15] s390x/tcg: use program_interrupt_ra() in STSI David Hildenbrand
2017-11-29 15:53 ` Cornelia Huck
2017-11-29 15:56 ` David Hildenbrand
2017-11-29 18:14 ` Richard Henderson
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 14/15] s390x/tcg: drop program_interrupt() David Hildenbrand
2017-11-29 15:55 ` Cornelia Huck
2017-11-29 18:18 ` Richard Henderson
2017-11-29 18:57 ` David Hildenbrand
2017-11-28 20:33 ` [Qemu-devel] [PATCH v1 for-2.12 15/15] s390x/tcg: drop potential_page_fault() David Hildenbrand
2017-11-29 18:20 ` Richard Henderson
2017-11-29 13:51 ` [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 00/15] s390x/tcg: cleanup and fix program interrupts Thomas Huth
2017-11-29 14:06 ` David Hildenbrand
2017-11-29 14:44 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128203326.6062-10-david@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).