From: Alex Williamson <alex.williamson@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH qemu] vfio-pci: Remove unused fields from VFIOMSIXInfo
Date: Wed, 29 Nov 2017 08:36:24 -0700 [thread overview]
Message-ID: <20171129083624.134d46ce@t450s.home> (raw)
In-Reply-To: <20171122073947.19325-1-aik@ozlabs.ru>
On Wed, 22 Nov 2017 18:39:47 +1100
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
Missing reference to commit that made these fields unused. A Fixes tag
to that commit also seems appropriate. An empty commit log is pretty
much never justified. This also looks like 2.12 material. Thanks,
Alex
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> hw/vfio/pci.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
> index c5e168e..06dcf99 100644
> --- a/hw/vfio/pci.h
> +++ b/hw/vfio/pci.h
> @@ -93,8 +93,6 @@ typedef struct VFIOMSIXInfo {
> uint16_t entries;
> uint32_t table_offset;
> uint32_t pba_offset;
> - MemoryRegion mmap_mem;
> - void *mmap;
> unsigned long *pending;
> } VFIOMSIXInfo;
>
next prev parent reply other threads:[~2017-11-29 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 7:39 [Qemu-devel] [PATCH qemu] vfio-pci: Remove unused fields from VFIOMSIXInfo Alexey Kardashevskiy
2017-11-22 8:21 ` no-reply
2017-11-29 15:36 ` Alex Williamson [this message]
2017-11-30 1:56 ` Alexey Kardashevskiy
2017-11-30 2:05 ` Alex Williamson
2017-11-30 6:27 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129083624.134d46ce@t450s.home \
--to=alex.williamson@redhat.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).