From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, jcody@redhat.com,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
pbonzini@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>
Subject: [Qemu-devel] [PATCH RFC 5/9] qed: Implement AioContext drain ops
Date: Wed, 29 Nov 2017 22:49:52 +0800 [thread overview]
Message-ID: <20171129144956.11409-6-famz@redhat.com> (raw)
In-Reply-To: <20171129144956.11409-1-famz@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/qed.c | 34 +++++++++++++++++++++++++---------
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index 821dcaa055..8ddaa31e7c 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -337,12 +337,33 @@ static void qed_cancel_need_check_timer(BDRVQEDState *s)
timer_del(s->need_check_timer);
}
+static void bdrv_qed_drained_begin(void *opaque)
+{
+ BlockDriverState *bs = opaque;
+ BDRVQEDState *s = bs->opaque;
+
+ /* Fire the timer immediately in order to start doing I/O as soon as the
+ * header is flushed.
+ */
+ if (s->need_check_timer && timer_pending(s->need_check_timer)) {
+ qed_cancel_need_check_timer(s);
+ qed_need_check_timer_entry(s);
+ }
+}
+
+static void bdrv_qed_drained_end(void *opaque)
+{
+}
+
static void bdrv_qed_detach_aio_context(BlockDriverState *bs)
{
BDRVQEDState *s = bs->opaque;
qed_cancel_need_check_timer(s);
timer_free(s->need_check_timer);
+ aio_context_del_drain_ops(bdrv_get_aio_context(bs),
+ bdrv_qed_drained_begin, bdrv_qed_drained_end,
+ bs);
}
static void bdrv_qed_attach_aio_context(BlockDriverState *bs,
@@ -356,19 +377,14 @@ static void bdrv_qed_attach_aio_context(BlockDriverState *bs,
if (s->header.features & QED_F_NEED_CHECK) {
qed_start_need_check_timer(s);
}
+ aio_context_add_drain_ops(new_context,
+ bdrv_qed_drained_begin, bdrv_qed_drained_end,
+ bs);
}
static void coroutine_fn bdrv_qed_co_drain_begin(BlockDriverState *bs)
{
- BDRVQEDState *s = bs->opaque;
-
- /* Fire the timer immediately in order to start doing I/O as soon as the
- * header is flushed.
- */
- if (s->need_check_timer && timer_pending(s->need_check_timer)) {
- qed_cancel_need_check_timer(s);
- qed_need_check_timer_entry(s);
- }
+ bdrv_qed_drained_begin(bs);
}
static void bdrv_qed_init_state(BlockDriverState *bs)
--
2.14.3
next prev parent reply other threads:[~2017-11-29 14:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 14:49 [Qemu-devel] [PATCH RFC 0/9] block: Rewrite block drain begin/end Fam Zheng
2017-11-29 14:49 ` [Qemu-devel] [PATCH RFC 1/9] block: Remove unused bdrv_requests_pending Fam Zheng
2017-12-01 12:35 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-11-29 14:49 ` [Qemu-devel] [PATCH RFC 2/9] aio: Add drain begin/end API to AioContext Fam Zheng
2017-11-30 16:07 ` Stefan Hajnoczi
2017-11-29 14:49 ` [Qemu-devel] [PATCH RFC 3/9] blockjob: Implement AioContext drain ops Fam Zheng
2017-11-30 16:09 ` Stefan Hajnoczi
2017-11-29 14:49 ` [Qemu-devel] [PATCH RFC 4/9] throttle: " Fam Zheng
2017-11-29 14:49 ` Fam Zheng [this message]
2017-11-29 14:49 ` [Qemu-devel] [PATCH RFC 6/9] block: Use aio_context_drained_begin in bdrv_set_aio_context Fam Zheng
2017-11-29 14:49 ` [Qemu-devel] [PATCH RFC 7/9] block: Switch to use AIO drained begin/end API Fam Zheng
2017-11-29 14:49 ` [Qemu-devel] [PATCH RFC 8/9] block: Drop old drained_{begin, end} callbacks Fam Zheng
2017-11-29 14:49 ` [Qemu-devel] [PATCH RFC 9/9] blockjob: Drop unused functions Fam Zheng
2017-11-29 17:25 ` [Qemu-devel] [PATCH RFC 0/9] block: Rewrite block drain begin/end Kevin Wolf
2017-11-30 2:03 ` Fam Zheng
2017-11-30 10:31 ` Kevin Wolf
2017-11-30 14:34 ` Fam Zheng
2017-11-30 15:10 ` Kevin Wolf
2017-11-30 16:04 ` Paolo Bonzini
2017-12-01 9:51 ` Fam Zheng
2017-12-01 12:24 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129144956.11409-6-famz@redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).