From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <somlo@cmu.edu>) id 1eK3rP-0006BE-B1
	for qemu-devel@nongnu.org; Wed, 29 Nov 2017 10:01:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <somlo@cmu.edu>) id 1eK3rK-0001tD-Gk
	for qemu-devel@nongnu.org; Wed, 29 Nov 2017 10:01:15 -0500
Received: from smtp.andrew.cmu.edu ([128.2.105.204]:34711)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <somlo@cmu.edu>) id 1eK3rK-0001sa-Cd
	for qemu-devel@nongnu.org; Wed, 29 Nov 2017 10:01:10 -0500
Date: Wed, 29 Nov 2017 10:01:05 -0500
From: "Gabriel L. Somlo" <somlo@cmu.edu>
Message-ID: <20171129150105.GK5774@hedwig.ini.cmu.edu>
References: <1511905227-30292-1-git-send-email-gomonovych@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1511905227-30292-1-git-send-email-gomonovych@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vasyl Gomonovych <gomonovych@gmail.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org

Acked-by: Gabriel Somlo <somlo@cmu.edu>

On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>  drivers/firmware/qemu_fw_cfg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 5cfe39f7a45f..18489b6a696d 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const struct kernel_param *kp)
>  	 */
>  	fw_cfg_cmdline_dev = platform_device_register_simple("fw_cfg",
>  					PLATFORM_DEVID_NONE, res, processed);
> -	if (IS_ERR(fw_cfg_cmdline_dev))
> -		return PTR_ERR(fw_cfg_cmdline_dev);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(fw_cfg_cmdline_dev);
>  }
>  
>  static int fw_cfg_cmdline_get(char *buf, const struct kernel_param *kp)
> -- 
> 1.9.1
>