From: Fam Zheng <famz@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/17] block/vmdk: Fix , instead of ; at end of line
Date: Thu, 30 Nov 2017 10:43:39 +0800 [thread overview]
Message-ID: <20171130024333.GD16237@lemon> (raw)
In-Reply-To: <20171123020832.8165-2-mreitz@redhat.com>
On Thu, 11/23 03:08, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/vmdk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index c665bcc977..1ae47b1c2e 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -1398,7 +1398,7 @@ static int vmdk_write_extent(VmdkExtent *extent, int64_t cluster_offset,
> qemu_iovec_concat(&local_qiov, qiov, qiov_offset, n_bytes);
> }
>
> - write_offset = cluster_offset + offset_in_cluster,
> + write_offset = cluster_offset + offset_in_cluster;
> ret = bdrv_co_pwritev(extent->file, write_offset, n_bytes,
> &local_qiov, 0);
>
> --
> 2.13.6
>
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-11-30 2:43 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 2:08 [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options Max Reitz
2017-11-23 2:08 ` [Qemu-devel] [PATCH 01/17] block/vmdk: Fix , instead of ; at end of line Max Reitz
2017-11-29 16:20 ` Eric Blake
2017-11-30 2:43 ` Fam Zheng [this message]
2017-11-23 2:08 ` [Qemu-devel] [PATCH 02/17] qcow2: No persistent dirty bitmaps for compat=0.10 Max Reitz
2017-11-29 16:23 ` Eric Blake
2017-11-23 2:08 ` [Qemu-devel] [PATCH 03/17] block/qcow: Add blkdebug events Max Reitz
2017-11-30 15:38 ` Eric Blake
2017-11-23 2:08 ` [Qemu-devel] [PATCH 04/17] block/vmdk: " Max Reitz
2017-11-30 2:58 ` Fam Zheng
2017-11-23 2:08 ` [Qemu-devel] [PATCH 05/17] iotests: Fix _img_info for backslashes Max Reitz
2017-11-30 2:59 ` Fam Zheng
2017-11-23 2:08 ` [Qemu-devel] [PATCH 06/17] iotests: Drop format-specific in _filter_img_info Max Reitz
2017-11-30 3:16 ` Fam Zheng
2017-11-30 13:22 ` Max Reitz
2017-11-30 15:42 ` Eric Blake
2017-12-01 1:33 ` Fam Zheng
2017-11-30 15:44 ` Eric Blake
2017-11-23 2:08 ` [Qemu-devel] [PATCH 07/17] iotests: Forbid 020 for non-file protocols Max Reitz
2017-11-30 2:52 ` Fam Zheng
2017-11-23 2:08 ` [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1 Max Reitz
2017-11-30 3:18 ` Fam Zheng
2017-11-30 13:23 ` Max Reitz
2017-12-09 1:36 ` John Snow
2017-12-11 17:17 ` Max Reitz
2017-12-11 17:35 ` John Snow
2017-11-23 2:08 ` [Qemu-devel] [PATCH 09/17] iotests: Disable some tests for compat=0.10 Max Reitz
2017-12-09 1:46 ` John Snow
2017-12-09 16:53 ` Eric Blake
2018-01-17 13:41 ` Max Reitz
2018-01-17 16:56 ` Eric Blake
2017-11-23 2:08 ` [Qemu-devel] [PATCH 10/17] iotests: Fix 020 for vmdk Max Reitz
2017-11-29 22:12 ` John Snow
2017-11-30 2:44 ` Fam Zheng
2017-11-23 2:08 ` [Qemu-devel] [PATCH 11/17] iotests: Fix 051 for compat=0.10 Max Reitz
2017-11-23 2:08 ` [Qemu-devel] [PATCH 12/17] iotests: Fix 059's reference output Max Reitz
2017-11-29 22:11 ` John Snow
2017-11-30 2:43 ` Fam Zheng
2017-11-23 2:08 ` [Qemu-devel] [PATCH 13/17] iotests: Fix 067 for compat=0.10 Max Reitz
2017-12-09 1:07 ` John Snow
2017-11-23 2:08 ` [Qemu-devel] [PATCH 14/17] iotests: Make 089 compatible with compat=0.10 Max Reitz
2017-12-09 1:08 ` John Snow
2017-11-23 2:08 ` [Qemu-devel] [PATCH 15/17] iotests: Make 184 image-less Max Reitz
2017-12-09 1:12 ` John Snow
2017-11-23 2:08 ` [Qemu-devel] [PATCH 16/17] iotests: Make 191 work with qcow2 options Max Reitz
2017-12-09 1:31 ` John Snow
2017-11-23 2:08 ` [Qemu-devel] [PATCH 17/17] iotests: Filter compat-dependent info in 198 Max Reitz
2017-12-09 1:33 ` John Snow
2017-11-23 2:12 ` [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options Max Reitz
2017-11-23 2:51 ` no-reply
2017-11-23 7:24 ` Fam Zheng
2017-11-27 15:00 ` Max Reitz
2017-11-29 19:24 ` [Qemu-devel] [PATCH 18/17] iotests: Make 059 pass on machines with little RAM Max Reitz
2017-11-30 2:51 ` Fam Zheng
2018-01-17 13:41 ` [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130024333.GD16237@lemon \
--to=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).