* [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c
@ 2017-11-30 14:05 Cornelia Huck
2017-11-30 14:27 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Cornelia Huck @ 2017-11-30 14:05 UTC (permalink / raw)
To: qemu-devel, qemu-s390x
Cc: rth, agraf, borntraeger, david, thuth, Cornelia Huck
It is not used anywhere.
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
target/s390x/helper.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/target/s390x/helper.c b/target/s390x/helper.c
index 246ba20f0d..35d9741918 100644
--- a/target/s390x/helper.c
+++ b/target/s390x/helper.c
@@ -31,24 +31,6 @@
#include "sysemu/sysemu.h"
#endif
-//#define DEBUG_S390
-//#define DEBUG_S390_STDOUT
-
-#ifdef DEBUG_S390
-#ifdef DEBUG_S390_STDOUT
-#define DPRINTF(fmt, ...) \
- do { fprintf(stderr, fmt, ## __VA_ARGS__); \
- if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
- do { qemu_log(fmt, ## __VA_ARGS__); } while (0)
-#endif
-#else
-#define DPRINTF(fmt, ...) \
- do { } while (0)
-#endif
-
-
#ifndef CONFIG_USER_ONLY
void s390x_tod_timer(void *opaque)
{
--
2.13.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c
2017-11-30 14:05 [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c Cornelia Huck
@ 2017-11-30 14:27 ` Eric Blake
2017-11-30 14:29 ` David Hildenbrand
2017-11-30 16:32 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Eric Blake @ 2017-11-30 14:27 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel, qemu-s390x
Cc: thuth, david, agraf, borntraeger, rth
On 11/30/2017 08:05 AM, Cornelia Huck wrote:
> It is not used anywhere.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> target/s390x/helper.c | 18 ------------------
> 1 file changed, 18 deletions(-)
Yay! One less spot for bit-rotten debug.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c
2017-11-30 14:05 [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c Cornelia Huck
2017-11-30 14:27 ` Eric Blake
@ 2017-11-30 14:29 ` David Hildenbrand
2017-11-30 15:50 ` Thomas Huth
2017-11-30 16:32 ` Cornelia Huck
2 siblings, 1 reply; 5+ messages in thread
From: David Hildenbrand @ 2017-11-30 14:29 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel, qemu-s390x; +Cc: rth, agraf, borntraeger, thuth
On 30.11.2017 15:05, Cornelia Huck wrote:
> It is not used anywhere.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> target/s390x/helper.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index 246ba20f0d..35d9741918 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -31,24 +31,6 @@
> #include "sysemu/sysemu.h"
> #endif
>
> -//#define DEBUG_S390
> -//#define DEBUG_S390_STDOUT
> -
> -#ifdef DEBUG_S390
> -#ifdef DEBUG_S390_STDOUT
> -#define DPRINTF(fmt, ...) \
> - do { fprintf(stderr, fmt, ## __VA_ARGS__); \
> - if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { qemu_log(fmt, ## __VA_ARGS__); } while (0)
> -#endif
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { } while (0)
> -#endif
> -
> -
> #ifndef CONFIG_USER_ONLY
> void s390x_tod_timer(void *opaque)
> {
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c
2017-11-30 14:05 [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c Cornelia Huck
2017-11-30 14:27 ` Eric Blake
2017-11-30 14:29 ` David Hildenbrand
@ 2017-11-30 16:32 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2017-11-30 16:32 UTC (permalink / raw)
To: qemu-devel, qemu-s390x; +Cc: rth, agraf, borntraeger, david, thuth
On Thu, 30 Nov 2017 15:05:36 +0100
Cornelia Huck <cohuck@redhat.com> wrote:
> It is not used anywhere.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> target/s390x/helper.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index 246ba20f0d..35d9741918 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -31,24 +31,6 @@
> #include "sysemu/sysemu.h"
> #endif
>
> -//#define DEBUG_S390
> -//#define DEBUG_S390_STDOUT
> -
> -#ifdef DEBUG_S390
> -#ifdef DEBUG_S390_STDOUT
> -#define DPRINTF(fmt, ...) \
> - do { fprintf(stderr, fmt, ## __VA_ARGS__); \
> - if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { qemu_log(fmt, ## __VA_ARGS__); } while (0)
> -#endif
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { } while (0)
> -#endif
> -
> -
> #ifndef CONFIG_USER_ONLY
> void s390x_tod_timer(void *opaque)
> {
Queued to s390-next.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-30 16:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-30 14:05 [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c Cornelia Huck
2017-11-30 14:27 ` Eric Blake
2017-11-30 14:29 ` David Hildenbrand
2017-11-30 15:50 ` Thomas Huth
2017-11-30 16:32 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).