From: Stefan Hajnoczi <stefanha@gmail.com>
To: Vasyl Gomonovych <gomonovych@gmail.com>
Cc: somlo@cmu.edu, mst@redhat.com, qemu-devel@nongnu.org,
linux-kernel@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()
Date: Fri, 1 Dec 2017 10:15:25 +0000 [thread overview]
Message-ID: <20171201101525.GH23501@stefanha-x1.localdomain> (raw)
In-Reply-To: <1511905227-30292-1-git-send-email-gomonovych@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
> drivers/firmware/qemu_fw_cfg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2017-12-01 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 21:40 [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-29 15:01 ` Gabriel L. Somlo
2017-12-01 10:15 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201101525.GH23501@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=gomonovych@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).