* [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()
@ 2017-11-28 21:40 Vasyl Gomonovych
2017-11-29 15:01 ` Gabriel L. Somlo
2017-12-01 10:15 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Vasyl Gomonovych @ 2017-11-28 21:40 UTC (permalink / raw)
To: somlo, mst, qemu-devel; +Cc: linux-kernel, gomonovych
Fix ptr_ret.cocci warnings:
drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/firmware/qemu_fw_cfg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 5cfe39f7a45f..18489b6a696d 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const struct kernel_param *kp)
*/
fw_cfg_cmdline_dev = platform_device_register_simple("fw_cfg",
PLATFORM_DEVID_NONE, res, processed);
- if (IS_ERR(fw_cfg_cmdline_dev))
- return PTR_ERR(fw_cfg_cmdline_dev);
- return 0;
+ return PTR_ERR_OR_ZERO(fw_cfg_cmdline_dev);
}
static int fw_cfg_cmdline_get(char *buf, const struct kernel_param *kp)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()
2017-11-28 21:40 [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
@ 2017-11-29 15:01 ` Gabriel L. Somlo
2017-12-01 10:15 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Gabriel L. Somlo @ 2017-11-29 15:01 UTC (permalink / raw)
To: Vasyl Gomonovych; +Cc: mst, qemu-devel, linux-kernel
Acked-by: Gabriel Somlo <somlo@cmu.edu>
On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
> drivers/firmware/qemu_fw_cfg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 5cfe39f7a45f..18489b6a696d 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const struct kernel_param *kp)
> */
> fw_cfg_cmdline_dev = platform_device_register_simple("fw_cfg",
> PLATFORM_DEVID_NONE, res, processed);
> - if (IS_ERR(fw_cfg_cmdline_dev))
> - return PTR_ERR(fw_cfg_cmdline_dev);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(fw_cfg_cmdline_dev);
> }
>
> static int fw_cfg_cmdline_get(char *buf, const struct kernel_param *kp)
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()
2017-11-28 21:40 [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-29 15:01 ` Gabriel L. Somlo
@ 2017-12-01 10:15 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2017-12-01 10:15 UTC (permalink / raw)
To: Vasyl Gomonovych; +Cc: somlo, mst, qemu-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
> drivers/firmware/qemu_fw_cfg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-01 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-28 21:40 [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-29 15:01 ` Gabriel L. Somlo
2017-12-01 10:15 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).