Re: [Qemu-devel] [PATCH v4 0/4] Convert to realize and improve error handling

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

On Wed, Nov 22, 2017 at 11:08:42AM +0800, Mao Zhongyi wrote:
> This series mainly implements the conversions of ide, floppy and nvme
> device to realize. Add some error handling messages and remove the local
> variable local_err, use errp to propagate the error directly. Also
> fix the unusual function name.
> 
> v4:
>   -rebased it on top of block-next branch
> 
> v3:
>   -patch1: update the test output in 051  [John Snow]
>   -patch2: update the test putput in 172  [John Snow]
> 
> v2:
>   -use bool as the return type instead of int. [Markus Armbruster & Stefan Hajnoczi]
> 
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: Keith Busch <keith.busch@intel.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> 
> Mao Zhongyi (4):
>   hw/block/nvme: Convert to realize
>   hw/block: Fix the return type
>   hw/block: Use errp directly rather than local_err
>   dev-storage: Fix the unusual function name
> 
>  hw/block/block.c                | 15 +++++++++------
>  hw/block/dataplane/virtio-blk.c | 12 +++++++-----
>  hw/block/dataplane/virtio-blk.h |  2 +-
>  hw/block/fdc.c                  | 17 ++++++-----------
>  hw/block/nvme.c                 | 23 +++++++++++------------
>  hw/block/virtio-blk.c           | 18 ++++++------------
>  hw/ide/qdev.c                   | 12 ++++--------
>  hw/scsi/scsi-disk.c             | 13 ++++---------
>  hw/usb/dev-storage.c            | 29 +++++++++++++----------------
>  include/hw/block/block.h        |  4 ++--
>  10 files changed, 63 insertions(+), 82 deletions(-)

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]