From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration
Date: Fri, 1 Dec 2017 13:58:07 +0100 [thread overview]
Message-ID: <20171201125813.1437-1-quintela@redhat.com> (raw)
Hi
This is on top of my info_migrate series.
CHanges:
- No more tests for deprecated parameters. Now I only use
migrate_set_parameter. If there is a deprecated command for that,
we tests it there.
- free "result" string, always good to return memory (Peter found it)
- use the new tcp_port parameter from info migrate. So we are
handling well the tcp case.
- lots of code movement around to make everything consistent.
- Several patches already integrated upstream.
Later, Juan.
[v2]
- to make review easier, I started renaming postcopy-test.c to migration-test.c
- Did cleanups/refactoring there
- Don't use global-qtest anymore
- check that the parameters that we sent got really set
- RFH: comrpress threads tests is not working for some weird reason. Using the same code on command line works.
still investigating why.
ToDoo:
- tcp: after discussions with dave, we ended in conclusion that we
need to use the 0 port and let the system gives us a free one
But .... that means that we need to be able to get that port back somehow.
"info migrate" woring on destination side?
- compression threads. There is some weird interaction with the test
hardness and every migration thread get waiting in a different
semaphore. Investigating if it is a race/bug/whateverr
- deprecated commands: There was a suggestion to make
migrate_set_parameter look at the parameter name and test old/new
depending on something. Not sure what to do here.
- testing commands: Is there a way to launch qemu and just sent
qmp/hmp commands without having to really run anything else?
Please review,.
Later, Juan.
[v1]
- add test for precopy for unix/tcp
exec and fd to came, don't know how to test rdma without hardware
- add tests using deprecated interfaces
- add test for xbzrle
Note to myself, there is no way to set the cache size with migraton_set_parameters
- Add test for compress threads
disabled on the series, right now it appears that compression is not working at all
- Move postcopy to use new results
Idea is to move it on top of migration-test.c, but first I want some reviews on basic idea
Please, review.
Juan.
Juan Quintela (6):
migration: free result string
tests: migration test deprecated commands
tests: Add migration precopy test
tests: Add basic migration precopy tcp test
tests: Add migration xbzrle test
[RFH] tests: Add migration compress threads tests
tests/migration-test.c | 257 +++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 247 insertions(+), 10 deletions(-)
--
2.14.3
next reply other threads:[~2017-12-01 16:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 12:58 Juan Quintela [this message]
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 1/6] migration: free result string Juan Quintela
2017-12-08 10:38 ` Dr. David Alan Gilbert
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 2/6] tests: migration test deprecated commands Juan Quintela
2017-12-05 7:36 ` Peter Xu
2017-12-26 19:51 ` Juan Quintela
2017-12-27 3:00 ` Peter Xu
2017-12-27 9:41 ` Juan Quintela
2017-12-27 10:11 ` Peter Xu
2017-12-08 10:44 ` Dr. David Alan Gilbert
2017-12-26 19:53 ` Juan Quintela
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 3/6] tests: Add migration precopy test Juan Quintela
2017-12-08 11:01 ` Dr. David Alan Gilbert
2017-12-26 19:57 ` Juan Quintela
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 4/6] tests: Add basic migration precopy tcp test Juan Quintela
2017-12-08 11:22 ` Dr. David Alan Gilbert
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 5/6] tests: Add migration xbzrle test Juan Quintela
2017-12-08 11:42 ` Dr. David Alan Gilbert
2017-12-26 20:02 ` Juan Quintela
2018-01-05 19:21 ` Juan Quintela
2018-01-05 19:41 ` Dr. David Alan Gilbert
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 6/6] [RFH] tests: Add migration compress threads tests Juan Quintela
2017-12-08 11:46 ` Dr. David Alan Gilbert
2017-12-26 20:07 ` Juan Quintela
2017-12-01 18:30 ` [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration Eric Blake
2017-12-01 18:38 ` Laurent Vivier
2017-12-01 18:44 ` Eric Blake
2018-01-02 20:52 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201125813.1437-1-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).