qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v3 5/6] tests: Add migration xbzrle test
Date: Fri,  1 Dec 2017 13:58:12 +0100	[thread overview]
Message-ID: <20171201125813.1437-6-quintela@redhat.com> (raw)
In-Reply-To: <20171201125813.1437-1-quintela@redhat.com>

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 tests/migration-test.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)

diff --git a/tests/migration-test.c b/tests/migration-test.c
index 841c89e28a..41dee78a9a 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -410,6 +410,20 @@ static void deprecated_set_speed(QTestState *who, const char *value)
     migrate_check_parameter(who, "max-bandwidth", value);
 }
 
+static void deprecated_set_cache_size(QTestState *who, const char *value)
+{
+    QDict *rsp;
+    gchar *cmd;
+
+    cmd = g_strdup_printf("{ 'execute': 'migrate-set-cache-size',"
+                          "'arguments': { 'value': %s } }", value);
+    rsp = qtest_qmp(who, cmd);
+    g_free(cmd);
+    g_assert(qdict_haskey(rsp, "return"));
+    QDECREF(rsp);
+    migrate_check_parameter(who, "xbzrle-cache-size", value);
+}
+
 static void migrate_set_parameter(QTestState *who, const char *parameter,
                                   const char *value)
 {
@@ -424,6 +438,10 @@ static void migrate_set_parameter(QTestState *who, const char *parameter,
         deprecated_set_speed(who, "12345");
     }
 
+    if (strcmp(parameter, "xbzrle-cache-size") == 0) {
+        deprecated_set_cache_size(who, "4096");
+    }
+
     cmd = g_strdup_printf("{ 'execute': 'migrate-set-parameters',"
                           "'arguments': { '%s': %s } }",
                           parameter, value);
@@ -673,6 +691,55 @@ static void test_precopy_tcp(void)
     g_free(port);
 }
 
+static void test_xbzrle(const char *uri)
+{
+    QTestState *from, *to;
+
+    test_migrate_start(&from, &to, uri);
+
+    /* We want to pick a speed slow enough that the test completes
+     * quickly, but that it doesn't complete precopy even on a slow
+     * machine, so also set the downtime.
+     */
+    /* 100 ms */
+    migrate_set_parameter(from, "downtime-limit", "1");
+    /* 1MB/s slow*/
+    migrate_set_parameter(from, "max-bandwidth", "1000000000");
+
+    migrate_set_parameter(from, "xbzrle-cache-size", "33554432");
+
+    migrate_set_capability(from, "xbzrle", "true");
+    migrate_set_capability(to, "xbzrle", "true");
+    /* Wait for the first serial output from the source */
+    wait_for_serial("src_serial");
+
+    migrate(from, uri);
+
+    wait_for_migration_pass(from);
+
+    /* 300ms it should converge */
+    migrate_set_parameter(from, "downtime-limit", "300");
+
+    if (!got_stop) {
+        qtest_qmp_eventwait(from, "STOP");
+    }
+    qtest_qmp_eventwait(to, "RESUME");
+
+    wait_for_serial("dest_serial");
+    wait_for_migration_complete(from);
+
+    test_migrate_end(from, to);
+}
+
+static void test_xbzrle_unix(void)
+{
+    char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
+
+    test_xbzrle(uri);
+    g_free(uri);
+}
+
+
 int main(int argc, char **argv)
 {
     char template[] = "/tmp/migration-test-XXXXXX";
@@ -695,6 +762,7 @@ int main(int argc, char **argv)
     qtest_add_func("/migration/precopy/unix", test_precopy_unix);
     qtest_add_func("/migration/precopy/tcp", test_precopy_tcp);
     qtest_add_func("/migration/postcopy/unix", test_postcopy);
+    qtest_add_func("/migration/xbzrle/unix", test_xbzrle_unix);
 
     ret = g_test_run();
 
-- 
2.14.3

  parent reply	other threads:[~2017-12-01 16:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 12:58 [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration Juan Quintela
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 1/6] migration: free result string Juan Quintela
2017-12-08 10:38   ` Dr. David Alan Gilbert
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 2/6] tests: migration test deprecated commands Juan Quintela
2017-12-05  7:36   ` Peter Xu
2017-12-26 19:51     ` Juan Quintela
2017-12-27  3:00       ` Peter Xu
2017-12-27  9:41         ` Juan Quintela
2017-12-27 10:11           ` Peter Xu
2017-12-08 10:44   ` Dr. David Alan Gilbert
2017-12-26 19:53     ` Juan Quintela
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 3/6] tests: Add migration precopy test Juan Quintela
2017-12-08 11:01   ` Dr. David Alan Gilbert
2017-12-26 19:57     ` Juan Quintela
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 4/6] tests: Add basic migration precopy tcp test Juan Quintela
2017-12-08 11:22   ` Dr. David Alan Gilbert
2017-12-01 12:58 ` Juan Quintela [this message]
2017-12-08 11:42   ` [Qemu-devel] [PATCH v3 5/6] tests: Add migration xbzrle test Dr. David Alan Gilbert
2017-12-26 20:02     ` Juan Quintela
2018-01-05 19:21     ` Juan Quintela
2018-01-05 19:41       ` Dr. David Alan Gilbert
2017-12-01 12:58 ` [Qemu-devel] [PATCH v3 6/6] [RFH] tests: Add migration compress threads tests Juan Quintela
2017-12-08 11:46   ` Dr. David Alan Gilbert
2017-12-26 20:07     ` Juan Quintela
2017-12-01 18:30 ` [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration Eric Blake
2017-12-01 18:38   ` Laurent Vivier
2017-12-01 18:44     ` Eric Blake
2018-01-02 20:52       ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201125813.1437-6-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).