From: Eric Farman <farman@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
"Richard W . M . Jones" <rjones@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Cc: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>,
Felipe Franciosi <felipe@nutanix.com>,
qemu-devel@nongnu.org, Eric Farman <farman@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter
Date: Fri, 1 Dec 2017 16:15:38 +0100 [thread overview]
Message-ID: <20171201151538.6844-2-farman@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171201151538.6844-1-farman@linux.vnet.ibm.com>
Commit 5c0919d02066 ("virtio-scsi: Add virtqueue_size parameter allowing
virtqueue size to be set.") introduced a new parameter to virtio-scsi.
Later, commit 920036106044 ("vhost-user-scsi: add missing virtqueue_size
param") added that parameter to the new vhost-user-scsi interface but
neglected the existing vhost-scsi interface it was built on.
Apply the same change to vhost-scsi, so that we can boot a guest with
a device defined. This also avoids crashing a guest when hotplugging
a vhost-scsi device.
Signed-off-by: Eric Farman <farman@linux.vnet.ibm.com>
---
hw/scsi/vhost-scsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index cd4ab05233..9c1bea8ff3 100644
--- a/hw/scsi/vhost-scsi.c
+++ b/hw/scsi/vhost-scsi.c
@@ -233,6 +233,8 @@ static Property vhost_scsi_properties[] = {
DEFINE_PROP_STRING("wwpn", VirtIOSCSICommon, conf.wwpn),
DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, 0),
DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues, 1),
+ DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon, conf.virtqueue_size,
+ 128),
DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, conf.max_sectors,
0xFFFF),
DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, conf.cmd_per_lun, 128),
--
2.13.5
next prev parent reply other threads:[~2017-12-01 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 15:15 [Qemu-devel] [PATCH for 2.11 0/1] Fix guest boot with vhost-scsi Eric Farman
2017-12-01 15:15 ` Eric Farman [this message]
2017-12-01 15:16 ` [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter Paolo Bonzini
2017-12-04 17:52 ` Eric Farman
2017-12-04 18:05 ` Peter Maydell
2017-12-04 20:00 ` Eric Farman
2017-12-05 0:59 ` Michael S. Tsirkin
2017-12-05 12:40 ` Peter Maydell
2017-12-05 18:10 ` Eric Farman
2017-12-02 11:35 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201151538.6844-2-farman@linux.vnet.ibm.com \
--to=farman@linux.vnet.ibm.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=felipe@nutanix.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).