qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <shajnocz@redhat.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	mdroth@linux.vnet.ibm.com, peterx@redhat.com,
	Eric Blake <eblake@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	marcandre.lureau@redhat.com,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [RFC v5 04/26] monitor: move skip_flush into monitor_data_init
Date: Tue,  5 Dec 2017 13:51:38 +0800	[thread overview]
Message-ID: <20171205055200.16305-5-peterx@redhat.com> (raw)
In-Reply-To: <20171205055200.16305-1-peterx@redhat.com>

It's part of the data init.  Collect it.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 monitor.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/monitor.c b/monitor.c
index e36fb5308d..3940737c1c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -568,13 +568,14 @@ static void monitor_qapi_event_init(void)
 
 static void handle_hmp_command(Monitor *mon, const char *cmdline);
 
-static void monitor_data_init(Monitor *mon)
+static void monitor_data_init(Monitor *mon, bool skip_flush)
 {
     memset(mon, 0, sizeof(Monitor));
     qemu_mutex_init(&mon->out_lock);
     mon->outbuf = qstring_new();
     /* Use *mon_cmds by default. */
     mon->cmd_table = mon_cmds;
+    mon->skip_flush = skip_flush;
 }
 
 static void monitor_data_destroy(Monitor *mon)
@@ -595,8 +596,7 @@ char *qmp_human_monitor_command(const char *command_line, bool has_cpu_index,
     char *output = NULL;
     Monitor *old_mon, hmp;
 
-    monitor_data_init(&hmp);
-    hmp.skip_flush = true;
+    monitor_data_init(&hmp, true);
 
     old_mon = cur_mon;
     cur_mon = &hmp;
@@ -4089,7 +4089,7 @@ void monitor_init(Chardev *chr, int flags)
     }
 
     mon = g_malloc(sizeof(*mon));
-    monitor_data_init(mon);
+    monitor_data_init(mon, false);
 
     qemu_chr_fe_init(&mon->chr, chr, &error_abort);
     mon->flags = flags;
-- 
2.14.3

  parent reply	other threads:[~2017-12-05  5:52 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05  5:51 [Qemu-devel] [RFC v5 00/26] QMP: out-of-band (OOB) execution support Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 01/26] qobject: introduce qstring_get_try_str() Peter Xu
2017-12-13 15:25   ` Stefan Hajnoczi
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 02/26] qobject: introduce qobject_get_try_str() Peter Xu
2017-12-13 15:25   ` Stefan Hajnoczi
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 03/26] qobject: let object_property_get_str() use new API Peter Xu
2017-12-13 15:27   ` Stefan Hajnoczi
2017-12-05  5:51 ` Peter Xu [this message]
2017-12-13 15:28   ` [Qemu-devel] [RFC v5 04/26] monitor: move skip_flush into monitor_data_init Stefan Hajnoczi
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 05/26] qjson: add "opaque" field to JSONMessageParser Peter Xu
2017-12-13 15:37   ` Stefan Hajnoczi
2017-12-15  7:55     ` Peter Xu
2017-12-15 12:45       ` Stefan Hajnoczi
2017-12-16  3:28         ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 06/26] monitor: move the cur_mon hack deeper for QMP Peter Xu
2017-12-13 15:41   ` Stefan Hajnoczi
2017-12-15  8:02     ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 07/26] monitor: unify global init Peter Xu
2017-12-13 15:48   ` Stefan Hajnoczi
2017-12-15  8:11     ` Peter Xu
2017-12-15 12:47       ` Stefan Hajnoczi
2017-12-16  3:52         ` Peter Xu
2017-12-16  9:01           ` Stefan Hajnoczi
2017-12-18  3:27             ` Peter Xu
2017-12-18  9:24               ` Stefan Hajnoczi
2017-12-18 10:10                 ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 08/26] monitor: let mon_list be tail queue Peter Xu
2017-12-13 15:49   ` Stefan Hajnoczi
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 09/26] monitor: create monitor dedicate iothread Peter Xu
2017-12-13 16:20   ` Stefan Hajnoczi
2017-12-15  8:31     ` Peter Xu
2017-12-15 13:21       ` Stefan Hajnoczi
2017-12-16  4:42         ` Peter Xu
2017-12-16  4:50           ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 10/26] monitor: allow to use IO thread for parsing Peter Xu
2017-12-13 16:35   ` Stefan Hajnoczi
2017-12-15  8:50     ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 11/26] qmp: introduce QMPCapability Peter Xu
2017-12-13 16:56   ` Stefan Hajnoczi
2017-12-15  9:14     ` Peter Xu
2017-12-15  9:38       ` Fam Zheng
2017-12-16  3:58         ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 12/26] qmp: negociate QMP capabilities Peter Xu
2017-12-12 17:39   ` Dr. David Alan Gilbert
2017-12-13 17:19   ` Stefan Hajnoczi
2017-12-15  9:40     ` Fam Zheng
2017-12-15 13:26       ` Stefan Hajnoczi
2017-12-15 13:53         ` Fam Zheng
2017-12-16  5:34           ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 13/26] qmp: introduce some capability helpers Peter Xu
2017-12-12 17:44   ` Dr. David Alan Gilbert
2017-12-13 17:20   ` Stefan Hajnoczi
2017-12-15  9:42   ` Fam Zheng
2017-12-16  5:45     ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 14/26] monitor: introduce monitor_qmp_respond() Peter Xu
2017-12-13 17:35   ` Stefan Hajnoczi
2017-12-16  5:52     ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 15/26] monitor: let suspend_cnt be thread safe Peter Xu
2017-12-13 18:43   ` Stefan Hajnoczi
2017-12-16  6:12     ` Peter Xu
2017-12-16  9:11       ` Stefan Hajnoczi
2017-12-18  5:16         ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher Peter Xu
2017-12-13 20:09   ` Stefan Hajnoczi
2017-12-16  6:37     ` Peter Xu
2017-12-16  6:46       ` Peter Xu
2017-12-16  9:23       ` Stefan Hajnoczi
2017-12-18  5:26         ` Peter Xu
2017-12-18  9:10           ` Stefan Hajnoczi
2017-12-18 10:03             ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 17/26] qmp: add new event "request-dropped" Peter Xu
2017-12-14 11:16   ` Stefan Hajnoczi
2017-12-16  6:59     ` Peter Xu
2017-12-14 11:32   ` Stefan Hajnoczi
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 18/26] monitor: send event when request queue full Peter Xu
2017-12-14 11:41   ` Stefan Hajnoczi
2017-12-16  7:17     ` Peter Xu
2017-12-16  9:28       ` Stefan Hajnoczi
2017-12-18  5:32         ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 19/26] qapi: introduce new cmd option "allow-oob" Peter Xu
2017-12-14 12:42   ` Stefan Hajnoczi
2017-12-15  9:51   ` Fam Zheng
2017-12-16  7:34     ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 20/26] qmp: support out-of-band (oob) execution Peter Xu
2017-12-14 13:16   ` Stefan Hajnoczi
2017-12-18  5:37     ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 21/26] qmp: isolate responses into io thread Peter Xu
2017-12-14 13:43   ` Stefan Hajnoczi
2017-12-18  5:52     ` Peter Xu
2017-12-18  7:32       ` Peter Xu
2017-12-18  8:40         ` Stefan Hajnoczi
2017-12-18 10:15           ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 22/26] monitor: enable IO thread for (qmp & !mux) typed Peter Xu
2017-12-14 13:44   ` Stefan Hajnoczi
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 23/26] qmp: add command "x-oob-test" Peter Xu
2017-12-14 13:45   ` Stefan Hajnoczi
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 24/26] docs: update QMP documents for OOB commands Peter Xu
2017-12-14 14:30   ` Stefan Hajnoczi
2017-12-18  9:44     ` Peter Xu
2017-12-18 14:09       ` Stefan Hajnoczi
2017-12-19  3:18         ` Peter Xu
2017-12-05  5:51 ` [Qemu-devel] [RFC v5 25/26] tests: qmp-test: verify command batching Peter Xu
2017-12-14 14:39   ` Stefan Hajnoczi
2017-12-18  9:48     ` Peter Xu
2017-12-05  5:52 ` [Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test Peter Xu
2017-12-14 14:47   ` Stefan Hajnoczi
2017-12-18  9:51     ` Peter Xu
2017-12-18 13:59       ` Stefan Hajnoczi
2017-12-14 14:52 ` [Qemu-devel] [RFC v5 00/26] QMP: out-of-band (OOB) execution support Stefan Hajnoczi
2017-12-19  6:05   ` Peter Xu
2017-12-15 10:41 ` Fam Zheng
2017-12-15 11:43   ` Dr. David Alan Gilbert
2017-12-15 13:30   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171205055200.16305-5-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=shajnocz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).