From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM94w-00068L-T3 for qemu-devel@nongnu.org; Tue, 05 Dec 2017 03:59:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM94t-0001it-Qe for qemu-devel@nongnu.org; Tue, 05 Dec 2017 03:59:50 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54254 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eM94t-0001ig-K7 for qemu-devel@nongnu.org; Tue, 05 Dec 2017 03:59:47 -0500 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vB58xav8048243 for ; Tue, 5 Dec 2017 03:59:45 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 2enmj59fqa-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 05 Dec 2017 03:59:43 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Dec 2017 08:59:08 -0000 Date: Tue, 5 Dec 2017 09:59:06 +0100 From: Bjoern Walk References: <20171128134648.21530-1-cohuck@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <20171128134648.21530-1-cohuck@redhat.com> Message-Id: <20171205085906.GA3894@lagrange> Subject: Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, borntraeger@de.ibm.com, pasic@linux.vnet.ibm.com, pmorel@linux.vnet.ibm.com --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Cornelia Huck [2017-11-28, 02:46PM +0100]: > info qom-tree shows several devices under unattached that probably > should go somewhere. >=20 > The css bridge should attach to the machine, as it has a similar > purpose as e.g. a pci host bridge. >=20 > The autogenerated network devices should be in the same bucket as any > other device; I'm just not sure about the way I went about it. >=20 > The zpci devices are still problematic: I don't have a good idea where > they should show up. >=20 > Remaining in the unattached container are the sysbus, memory regions > and cpus. >=20 > Cornelia Huck (2): > s390x/css: attach css bridge > s390x: attach autogenerated nics >=20 > hw/s390x/css-bridge.c | 2 ++ > hw/s390x/s390-virtio-ccw.c | 2 ++ > 2 files changed, 4 insertions(+) >=20 > --=20 > 2.13.6 >=20 >=20 Regarding the discussion about whether the QOM tree is API and what exploiters like libvirt should do, Halil asked me to chip in. This patch is fine from libvirt perspective. I did a quick smoke test and you can have a Tested-by: Bjoern Walk for what it's worth. In general, I kind of agree with Halil. Unless somewhere in QEMU it is documented that the QOM tree is not guaranteed to be stable for exploiters, I'd consider is part of the API. libvirt does use at least some hardcoded paths, most of the time for CPUs in /machine/unattached, so if that relation would change, things break. However, there is also code to traverse the QOM tree recursively and find a path for a given type(?) name. If this is the preferred way, we probably should change this in libvirt to be safe. --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJqBAABCgBUFiEEBn4lu8U/QODL6lOpwRmEn/QXKiAFAlomX9I2FIAAAAAAFQAY cGthLWFkZHJlc3NAZ251cGcub3JnYndhbGtAbGludXgudm5ldC5pYm0uY29tAAoJ EMEZhJ/0Fyogx6sQAMvg3w5QQ6ckiPPXIwa1vhaU6jysI1EFFYgZcggyWkT9B1ci Nuy7q1YPTVL6OKt7UklaMPPpm8EmjSxuQ5+zXDa0IpUM4sMOku6BQRyu7TSHnJnL M+t3vOqXDzttDkhyoOzI6Adq2W8qjhfT5+AVwhxS5c7kLMIQ7eHfM+VqXMryOsuZ cvQNwGRJgUYujSeWCruWCc4PQvho1X3zkX798fyDHKYVR9NBkYDp2HWsgfhnCwje 4KafBKCiD7VUAps7O0BVOIZAfMT+qHfFUlUaRiyZws7SVPTyvD7ejxHeameSRDeA 1Y51jYlnuYsnbw1izRtku3z5fOf/us827VKOulslKXPo8eqhblzBodBJTWNGCHpB 3YPGW75v6eAb/T0ad5yPSlcukq/Rm/uerxsx9DOzmaaPYZ2gJ91rQTbkq+eRsZKY GgwsXPygwn+q9EempdRpSryjHAA8Y9Qhrs1/97jzK3WohNEcSl1AoXNh/xKL1EBm 9X+rtM53BVzto5GX9nhOUOezpQ0v+3DpIh4HwDDN4iiO4v0IE2Lmmo5+QtF/8/gM lbGQdWTi+4zsEF082NaIsE0dokEpGheczNrqrHIGyktaSp43tZXEIBPnjxhvQO26 7g29SEvkq5U+LHtT2tXDTlGet/5NWHn6OUKXQ0/BB/TD3tbAHbyVgSFKI120 =w2zU -----END PGP SIGNATURE----- --ibTvN161/egqYuK8--