From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-block@nongnu.org, pbonzini@redhat.com, famz@redhat.com,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] block: Make bdrv_drain_invoke() recursive
Date: Tue, 5 Dec 2017 16:23:51 +0100 [thread overview]
Message-ID: <20171205152351.GB4096@localhost.localdomain> (raw)
In-Reply-To: <a7c90b68-3b82-0fbb-332a-d2831fb97a74@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Am 05.12.2017 um 16:15 hat Eric Blake geschrieben:
> On 12/05/2017 08:54 AM, Kevin Wolf wrote:
> > This change separates bdrv_drain_invoke(), which calls the BlockDriver
> > drain callbacks, from bdrv_drain_recurse(). Instead, the function
> > performs its own recursion now.
> >
> > One reason for this is that bdrv_drain_recurse() can be called multiple
> > times bdrv_drain_recurse(),
>
> Doesn't read right. Should the second instance be changed to 'by
> itself', or is the correct meaning something else?
This should be "by bdrv_drain_all_begin()". Thanks!
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-12-05 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 14:54 [Qemu-devel] [PATCH 0/4] block: Fix BlockDriver callbacks in bdrv_drain_all_begin() Kevin Wolf
2017-12-05 14:54 ` [Qemu-devel] [PATCH 1/4] block: Make bdrv_drain_invoke() recursive Kevin Wolf
2017-12-05 15:02 ` Paolo Bonzini
2017-12-05 15:22 ` Kevin Wolf
2017-12-05 15:15 ` Eric Blake
2017-12-05 15:23 ` Kevin Wolf [this message]
2017-12-05 14:54 ` [Qemu-devel] [PATCH 2/4] block: Call .drain_begin only once in bdrv_drain_all_begin() Kevin Wolf
2017-12-05 14:54 ` [Qemu-devel] [PATCH 3/4] test-bdrv-drain: Test BlockDriver callbacks for drain Kevin Wolf
2017-12-05 14:54 ` [Qemu-devel] [PATCH 4/4] block: bdrv_drain_recurse(): Remove unused begin parameter Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205152351.GB4096@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).