From: Kevin Wolf <kwolf@redhat.com>
To: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Max Reitz <mreitz@redhat.com>,
qemu-devel@nongnu.org, Cleber Rosa <crosa@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/1] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test
Date: Wed, 6 Dec 2017 09:27:43 +0100 [thread overview]
Message-ID: <20171206082743.GB4207@localhost.localdomain> (raw)
In-Reply-To: <3b62cb3c-11d4-6215-1e14-b1abb9ba59d5@linux.vnet.ibm.com>
Am 05.12.2017 um 20:31 hat Daniel Henrique Barboza geschrieben:
> On 12/05/2017 04:06 PM, Dr. David Alan Gilbert wrote:
> > * Daniel Henrique Barboza (danielhb@linux.vnet.ibm.com) wrote:
> > > This patch implements a test case for the scenario that was failing
> > > prior to the patch "migration/ram.c: do not set 'postcopy_running' in
> > > POSTCOPY_INCOMING_END", commit acab30b85d.
> > >
> > > This new test file 201 was derived from the test file 181 authored
> > > by Kevin Wolf.
> > The test is interesting because it enables postcopy but never triggers
> > postcopy entry (using migrate_start_postcopy). Still it's a good path
> > to check.
> >
> > It will fail to enable postcopy on older linux hosts or non-linux hosts
> > that don't have userfault though; I'm not sure how your test fails
> > with that.
> Hmmm I am not sure either. I have tested it with Travis and it passed all
> tests,
> including a claimed Mac OS environment. Not sure if that counts.
>
> I'll see if I can get this tested on a Windows env to see how this test
> fails.
qemu-iotests is basically Linux-only and we don't even try to keep
things portable. If it works on Windows, that's more by accident than
intentional.
Kevin
prev parent reply other threads:[~2017-12-06 8:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 15:17 [Qemu-devel] [PATCH v4 0/1] savevm/loadvm with postcopy flag qemu-iotest Daniel Henrique Barboza
2017-12-04 15:17 ` [Qemu-devel] [PATCH v4 1/1] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test Daniel Henrique Barboza
2017-12-04 18:18 ` Max Reitz
2017-12-04 22:23 ` Max Reitz
2017-12-05 11:47 ` Daniel Henrique Barboza
2017-12-05 18:06 ` Dr. David Alan Gilbert
2017-12-05 19:31 ` Daniel Henrique Barboza
2017-12-05 19:43 ` Dr. David Alan Gilbert
2017-12-06 8:27 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206082743.GB4207@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=crosa@redhat.com \
--cc=danielhb@linux.vnet.ibm.com \
--cc=dgilbert@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).