From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Eric Blake <eblake@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v2 2/6] docs: mark nested AioContext locking as a legacy API
Date: Thu, 7 Dec 2017 20:13:16 +0000 [thread overview]
Message-ID: <20171207201320.19284-3-stefanha@redhat.com> (raw)
In-Reply-To: <20171207201320.19284-1-stefanha@redhat.com>
See the patch for why nested AioContext locking is no longer allowed.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
docs/devel/multiple-iothreads.txt | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/docs/devel/multiple-iothreads.txt b/docs/devel/multiple-iothreads.txt
index e4d340bbb7..4f9012d154 100644
--- a/docs/devel/multiple-iothreads.txt
+++ b/docs/devel/multiple-iothreads.txt
@@ -1,4 +1,4 @@
-Copyright (c) 2014 Red Hat Inc.
+Copyright (c) 2014-2017 Red Hat Inc.
This work is licensed under the terms of the GNU GPL, version 2 or later. See
the COPYING file in the top-level directory.
@@ -92,8 +92,9 @@ aio_context_acquire()/aio_context_release() for mutual exclusion. Once the
context is acquired no other thread can access it or run event loop iterations
in this AioContext.
-aio_context_acquire()/aio_context_release() calls may be nested. This
-means you can call them if you're not sure whether #2 applies.
+Legacy code sometimes nests aio_context_acquire()/aio_context_release() calls.
+Do not use nesting anymore, it is incompatible with the BDRV_POLL_WHILE() macro
+used in the block layer and can lead to hangs.
There is currently no lock ordering rule if a thread needs to acquire multiple
AioContexts simultaneously. Therefore, it is only safe for code holding the
--
2.14.3
next prev parent reply other threads:[~2017-12-07 20:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 20:13 [Qemu-devel] [PATCH v2 0/6] block: avoid recursive AioContext acquire in bdrv_inactivate_all() Stefan Hajnoczi
2017-12-07 20:13 ` [Qemu-devel] [PATCH v2 1/6] " Stefan Hajnoczi
2017-12-07 22:04 ` Eric Blake
2017-12-07 20:13 ` Stefan Hajnoczi [this message]
2017-12-07 22:34 ` [Qemu-devel] [PATCH v2 2/6] docs: mark nested AioContext locking as a legacy API Eric Blake
2017-12-07 20:13 ` [Qemu-devel] [PATCH v2 3/6] blockdev: add x-blockdev-set-iothread force boolean Stefan Hajnoczi
2017-12-07 22:38 ` Eric Blake
2017-12-07 20:13 ` [Qemu-devel] [PATCH v2 4/6] iotests: add VM.add_object() Stefan Hajnoczi
2017-12-07 22:39 ` Eric Blake
2017-12-07 20:13 ` [Qemu-devel] [PATCH v2 5/6] iothread: fix iothread_stop() race condition Stefan Hajnoczi
2017-12-07 22:42 ` Eric Blake
2017-12-07 20:13 ` [Qemu-devel] [PATCH v2 6/6] qemu-iotests: add 203 savevm with IOThreads test Stefan Hajnoczi
2017-12-07 22:46 ` Eric Blake
2017-12-13 21:23 ` [Qemu-devel] [PATCH v2 0/6] block: avoid recursive AioContext acquire in bdrv_inactivate_all() Paolo Bonzini
2017-12-14 11:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207201320.19284-3-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).