From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNGPo-0006SM-8c for qemu-devel@nongnu.org; Fri, 08 Dec 2017 06:02:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNGPl-0006Yj-3q for qemu-devel@nongnu.org; Fri, 08 Dec 2017 06:02:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47988) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eNGPk-0006YO-T4 for qemu-devel@nongnu.org; Fri, 08 Dec 2017 06:01:57 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BDD82C0050D9 for ; Fri, 8 Dec 2017 11:01:55 +0000 (UTC) Date: Fri, 8 Dec 2017 11:01:49 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20171208110148.GH2403@work-vm> References: <20171201125813.1437-1-quintela@redhat.com> <20171201125813.1437-4-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171201125813.1437-4-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 3/6] tests: Add migration precopy test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > Signed-off-by: Juan Quintela OK, although you seem to have chosen a bandwidth 10x what I use in the postcopy test but for the same reason. Reviewed-by: Dr. David Alan Gilbert > --- > tests/migration-test.c | 44 ++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 42 insertions(+), 2 deletions(-) > > diff --git a/tests/migration-test.c b/tests/migration-test.c > index 51f49c74e9..3f3f056be6 100644 > --- a/tests/migration-test.c > +++ b/tests/migration-test.c > @@ -539,7 +539,7 @@ static void test_migrate_end(QTestState *from, QTestState *to) > cleanup("dest_serial"); > } > > -static void test_migrate(void) > +static void test_postcopy(void) > { > char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs); > QTestState *from, *to; > @@ -582,6 +582,45 @@ static void test_migrate(void) > test_migrate_end(from, to); > } > > +static void test_precopy_unix(void) > +{ > + char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs); > + QTestState *from, *to; > + > + test_migrate_start(&from, &to, uri); > + > + /* We want to pick a speed slow enough that the test completes > + * quickly, but that it doesn't complete precopy even on a slow > + * machine, so also set the downtime. > + */ > + /* 1 ms */ > + migrate_set_parameter(from, "downtime-limit", "1"); > + /* 1GB/s slow*/ > + migrate_set_parameter(from, "max-bandwidth", "1000000000"); > + > + /* Wait for the first serial output from the source */ > + wait_for_serial("src_serial"); > + > + migrate(from, uri); > + > + wait_for_migration_pass(from); > + > + /* 300 ms should converge */ > + migrate_set_parameter(from, "downtime-limit", "300"); > + > + if (!got_stop) { > + qtest_qmp_eventwait(from, "STOP"); > + } > + > + qtest_qmp_eventwait(to, "RESUME"); > + > + wait_for_serial("dest_serial"); > + wait_for_migration_complete(from); > + > + test_migrate_end(from, to); > + g_free(uri); > +} > + > int main(int argc, char **argv) > { > char template[] = "/tmp/migration-test-XXXXXX"; > @@ -601,7 +640,8 @@ int main(int argc, char **argv) > > module_call_init(MODULE_INIT_QOM); > > - qtest_add_func("/migration/postcopy/unix", test_migrate); > + qtest_add_func("/migration/precopy/unix", test_precopy_unix); > + qtest_add_func("/migration/postcopy/unix", test_postcopy); > > ret = g_test_run(); > > -- > 2.14.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK