From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, imammedo@redhat.com
Cc: maxime.coquelin@redhat.com, mst@redhat.com, groug@kaod.org
Subject: [Qemu-devel] [RFC v2 0/8] Rework vhost memory region updates
Date: Fri, 8 Dec 2017 20:32:49 +0000 [thread overview]
Message-ID: <20171208203257.13102-1-dgilbert@redhat.com> (raw)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Hi,
This is an experimental set that reworks the way the vhost
code handles changes in physical address space layout that
came from a discussion with Igor.
It's intention is to simplify a lot of the update code,
and to make it easier for the postcopy+shared code to
do the hugepage alignments that are needed.
Instead of updating and trying to merge sections of address
space on each add/remove callback, we wait until the commit phase
and go through and rebuild a list by walking the Flatview of
memory and end up producing an ordered list.
We compare the list to the old list to trigger updates.
This is pretty lightly tested (not least because I can't
get vhost-user+hot-add memory to survive even upstream).
v2
Incorporate changes and code from Igor, in particular the simpler
ring verification checks and thus the removal of the complex
comparison code.
Dave
Dr. David Alan Gilbert (8):
memory: address_space_iterate
vhost: Move log_dirty check
vhost: Simplify ring verification checks
vhost: New memory update functions
vhost: update_mem_cb implementation
vhost: Compare and copy updated region data into device state
vhost: Remove old vhost_set_memory etc
vhost: Move mem_sections maintenance into commit/update routines
hw/virtio/trace-events | 7 +
hw/virtio/vhost.c | 504 ++++++++++++++++------------------------------
include/exec/memory.h | 23 +++
include/hw/virtio/vhost.h | 3 -
memory.c | 22 ++
5 files changed, 229 insertions(+), 330 deletions(-)
--
2.14.3
next reply other threads:[~2017-12-08 20:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 20:32 Dr. David Alan Gilbert (git) [this message]
2017-12-08 20:32 ` [Qemu-devel] [RFC v2 1/8] memory: address_space_iterate Dr. David Alan Gilbert (git)
2017-12-08 20:32 ` [Qemu-devel] [RFC v2 2/8] vhost: Move log_dirty check Dr. David Alan Gilbert (git)
2017-12-08 20:32 ` [Qemu-devel] [RFC v2 3/8] vhost: Simplify ring verification checks Dr. David Alan Gilbert (git)
2017-12-08 20:32 ` [Qemu-devel] [RFC v2 4/8] vhost: New memory update functions Dr. David Alan Gilbert (git)
2017-12-08 20:32 ` [Qemu-devel] [RFC v2 5/8] vhost: update_mem_cb implementation Dr. David Alan Gilbert (git)
2017-12-08 20:32 ` [Qemu-devel] [RFC v2 6/8] vhost: Compare and copy updated region data into device state Dr. David Alan Gilbert (git)
2017-12-08 20:32 ` [Qemu-devel] [RFC v2 7/8] vhost: Remove old vhost_set_memory etc Dr. David Alan Gilbert (git)
2017-12-08 20:32 ` [Qemu-devel] [RFC v2 8/8] vhost: Move mem_sections maintenance into commit/update routines Dr. David Alan Gilbert (git)
2017-12-11 10:32 ` [Qemu-devel] [RFC v2 0/8] Rework vhost memory region updates Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208203257.13102-1-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).