qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, kchamart@redhat.com,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U
Date: Mon, 11 Dec 2017 19:44:25 +0800	[thread overview]
Message-ID: <20171211114425.GD3350@lemon> (raw)
In-Reply-To: <20171211095044.GA7707@localhost.localdomain>

On Mon, 12/11 10:50, Kevin Wolf wrote:
> Am 11.12.2017 um 10:33 hat Fam Zheng geschrieben:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > 
> > ---
> > 
> > v3: Document that the option is not allowed for read-write. [Stefan]
> > 
> > v2: - "code{qemu-img}". [Kashyap, Eric]
> >     - "etc.." -> "etc.".
> > ---
> >  qemu-img.texi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/qemu-img.texi b/qemu-img.texi
> > index fdcf120f36..d85ace73f0 100644
> > --- a/qemu-img.texi
> > +++ b/qemu-img.texi
> > @@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use
> >  the @var{-n} parameter to skip image creation. This restriction may be relaxed
> >  in a future release.
> >  
> > +@item --force-share (-U)
> > +
> > +If specified, @code{qemu-img} will open the image with shared permissions,
> > +which makes it less likely to conflict with a running guest's permissions due
> > +to image locking. For example, this can be used to get the image information
> > +(with 'info' subcommand) when the image is used by a running guest. Note that
> > +this could produce inconsistent result because of concurrent metadata changes,
> > +etc. This option is only allowed when opening image in read-only mode.
> 
> I think "an image", "the image" or "images" could all work in this
> context, but just "image" without an article doesn't.

"Images" would be my intent if I proofread it, but you're right, all sound okay
to me. Thanks.

Fam

      reply	other threads:[~2017-12-11 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11  9:33 [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U Fam Zheng
2017-12-11  9:50 ` Kevin Wolf
2017-12-11 11:44   ` Fam Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211114425.GD3350@lemon \
    --to=famz@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).