From: Stefan Hajnoczi <stefanha@gmail.com>
To: Changpeng Liu <changpeng.liu@intel.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com,
marcandre.lureau@redhat.com, felipe@nutanix.com,
james.r.harris@intel.com
Subject: Re: [Qemu-devel] [PATCH v6 3/4] contrib/libvhost-user: enable virtio config space messages
Date: Mon, 11 Dec 2017 13:59:42 +0000 [thread overview]
Message-ID: <20171211135942.GC5962@stefanha-x1.localdomain> (raw)
In-Reply-To: <1512455239-8296-4-git-send-email-changpeng.liu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Tue, Dec 05, 2017 at 02:27:18PM +0800, Changpeng Liu wrote:
> @@ -798,6 +801,70 @@ vu_set_slave_req_fd(VuDev *dev, VhostUserMsg *vmsg)
> }
>
> static bool
> +vu_get_config(VuDev *dev, VhostUserMsg *vmsg)
> +{
> + int ret = -1;
> +
> + if (dev->iface->get_config) {
> + ret = dev->iface->get_config(dev, vmsg->payload.config.region,
> + vmsg->payload.config.size);
> + }
> +
> + if (ret) {
> + /* resize to zero to indicate an error to master */
> + vmsg->size = 0;
> + }
Please document this error case in vhost-user.txt. I don't remember
reading about it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-12-11 13:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 6:27 [Qemu-devel] [PATCH v6 0/4] Introduce a new vhost-user-blk host device to QEMU Changpeng Liu
2017-12-05 6:27 ` [Qemu-devel] [PATCH v6 1/4] vhost-user: add new vhost user messages to support virtio config space Changpeng Liu
2017-12-11 13:39 ` Stefan Hajnoczi
2017-12-12 1:25 ` Liu, Changpeng
2017-12-12 10:20 ` Stefan Hajnoczi
2017-12-05 6:27 ` [Qemu-devel] [PATCH v6 2/4] vhost-user-blk: introduce a new vhost-user-blk host device Changpeng Liu
2017-12-11 13:54 ` Stefan Hajnoczi
2017-12-05 6:27 ` [Qemu-devel] [PATCH v6 3/4] contrib/libvhost-user: enable virtio config space messages Changpeng Liu
2017-12-11 13:59 ` Stefan Hajnoczi [this message]
2017-12-12 1:26 ` Liu, Changpeng
2017-12-05 6:27 ` [Qemu-devel] [PATCH v6 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application Changpeng Liu
2017-12-11 14:33 ` Stefan Hajnoczi
2017-12-12 1:36 ` Liu, Changpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211135942.GC5962@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=changpeng.liu@intel.com \
--cc=felipe@nutanix.com \
--cc=james.r.harris@intel.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).