qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Liu, Changpeng" <changpeng.liu@intel.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>,
	"felipe@nutanix.com" <felipe@nutanix.com>,
	"Harris, James R" <james.r.harris@intel.com>
Subject: Re: [Qemu-devel] [PATCH v6 1/4] vhost-user: add new vhost user messages to support virtio config space
Date: Tue, 12 Dec 2017 10:20:32 +0000	[thread overview]
Message-ID: <20171212102032.GC6985@stefanha-x1.localdomain> (raw)
In-Reply-To: <FF7FC980937D6342B9D289F5F3C7C2625B5E5373@SHSMSX103.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Tue, Dec 12, 2017 at 01:25:30AM +0000, Liu, Changpeng wrote:
> > The vhost-blk code should also check that
> > hdev->vhost_ops->vhost_set_config != NULL during realize.  This way
> > users see the error when adding the device instead of at runtime when
> > the function gets called.
> For vhost-blk, get_config is mandatory, but for set_config, it should depend
> on the feature bit: VIRTIO_BLK_F_CONFIG_WCE is enabled or not. Of course,
> migration should be another case. So running time error process should be
> okay.

Okay.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2017-12-12 10:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05  6:27 [Qemu-devel] [PATCH v6 0/4] Introduce a new vhost-user-blk host device to QEMU Changpeng Liu
2017-12-05  6:27 ` [Qemu-devel] [PATCH v6 1/4] vhost-user: add new vhost user messages to support virtio config space Changpeng Liu
2017-12-11 13:39   ` Stefan Hajnoczi
2017-12-12  1:25     ` Liu, Changpeng
2017-12-12 10:20       ` Stefan Hajnoczi [this message]
2017-12-05  6:27 ` [Qemu-devel] [PATCH v6 2/4] vhost-user-blk: introduce a new vhost-user-blk host device Changpeng Liu
2017-12-11 13:54   ` Stefan Hajnoczi
2017-12-05  6:27 ` [Qemu-devel] [PATCH v6 3/4] contrib/libvhost-user: enable virtio config space messages Changpeng Liu
2017-12-11 13:59   ` Stefan Hajnoczi
2017-12-12  1:26     ` Liu, Changpeng
2017-12-05  6:27 ` [Qemu-devel] [PATCH v6 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application Changpeng Liu
2017-12-11 14:33   ` Stefan Hajnoczi
2017-12-12  1:36     ` Liu, Changpeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212102032.GC6985@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=changpeng.liu@intel.com \
    --cc=felipe@nutanix.com \
    --cc=james.r.harris@intel.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).