From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOhiV-0001UP-AO for qemu-devel@nongnu.org; Tue, 12 Dec 2017 05:23:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOhiQ-0004QG-CJ for qemu-devel@nongnu.org; Tue, 12 Dec 2017 05:23:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45262) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eOhiQ-0004PK-34 for qemu-devel@nongnu.org; Tue, 12 Dec 2017 05:23:10 -0500 Date: Tue, 12 Dec 2017 11:23:02 +0100 From: Igor Mammedov Message-ID: <20171212112302.7e6716da@redhat.com> In-Reply-To: <97feaaf8-b08e-2c49-6cdb-b1556f6326cd@redhat.com> References: <20171211194610.3962-1-dgilbert@redhat.com> <20171211194610.3962-2-dgilbert@redhat.com> <97feaaf8-b08e-2c49-6cdb-b1556f6326cd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/8] memory: address_space_iterate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org, maxime.coquelin@redhat.com, groug@kaod.org, mst@redhat.com On Tue, 12 Dec 2017 00:50:51 +0100 Paolo Bonzini wrote: > On 11/12/2017 20:46, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Iterate through an address space calling a function for each > > section. The iteration is done in order. > > > > Signed-off-by: Dr. David Alan Gilbert > > It seems to me that you can achieve the same effect by implementing the > region_add and region_nop callbacks, and leaving out region_del. Am I > missing something? region_del would also be need to track references correctly. Initially I've also suggested to reuse region_add|del but compared to David's approach it will be multiple calls for a memory transaction vs a pass over flatview at commit time. > > Thanks, > > Paolo > > > --- > > include/exec/memory.h | 23 +++++++++++++++++++++++ > > memory.c | 22 ++++++++++++++++++++++ > > 2 files changed, 45 insertions(+) > > > > diff --git a/include/exec/memory.h b/include/exec/memory.h > > index 5ed4042f87..f5a9df642e 100644 > > --- a/include/exec/memory.h > > +++ b/include/exec/memory.h > > @@ -1987,6 +1987,29 @@ address_space_write_cached(MemoryRegionCache *cache, hwaddr addr, > > address_space_write(cache->as, cache->xlat + addr, MEMTXATTRS_UNSPECIFIED, buf, len); > > } > > > > +/** > > + * ASIterateCallback: Function type called by address_space_iterate > > + * > > + * Return 0 on success or a negative error code. > > + * > > + * @mrs: Memory region section for this range > > + * @opaque: The opaque value passed in to the iterator. > > + */ > > +typedef int (*ASIterateCallback)(MemoryRegionSection *mrs, void *opaque); > > + > > +/** > > + * address_space_iterate: Call the function for each address range in the > > + * AddressSpace, in sorted order. > > + * > > + * Return 0 on success or a negative error code. > > + * > > + * @as: Address space to iterate over > > + * @cb: Function to call. If the function returns none-0 the iteration will > > + * stop. > > + * @opaque: Value to pass to the function > > + */ > > +int > > +address_space_iterate(AddressSpace *as, ASIterateCallback cb, void *opaque); > > #endif > > > > #endif > > diff --git a/memory.c b/memory.c > > index e26e5a3b1d..f45137f25e 100644 > > --- a/memory.c > > +++ b/memory.c > > @@ -2810,6 +2810,28 @@ void address_space_destroy(AddressSpace *as) > > call_rcu(as, do_address_space_destroy, rcu); > > } > > > > +int address_space_iterate(AddressSpace *as, ASIterateCallback cb, > > + void *opaque) > > +{ > > + int res = 0; > > + FlatView *fv = address_space_to_flatview(as); > > + FlatRange *range; > > + > > + flatview_ref(fv); > > + > > + FOR_EACH_FLAT_RANGE(range, fv) { > > + MemoryRegionSection mrs = section_from_flat_range(range, fv); > > + res = cb(&mrs, opaque); > > + if (res) { > > + break; > > + } > > + } > > + > > + flatview_unref(fv); > > + > > + return res; > > +} > > + > > static const char *memory_region_type(MemoryRegion *mr) > > { > > if (memory_region_is_ram_device(mr)) { > > >