Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

[Cornelia Huck <cohuck@redhat.com>]

On Tue, 12 Dec 2017 22:05:24 +0800
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote:

> * Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> [2017-12-05 15:43:00 +0800]:
> 
> > * Cornelia Huck <cohuck@redhat.com> [2017-12-04 17:11:24 +0100]:
> > 
> > [...]
> > 
> > This one looks good to me too, so:
> > Reviewed-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
> >   
> > > 
> > > (...)
> > >   
> > > > > Looks sane. We should put a note into the 2.12 changelog as well.
> > > > >     
> > > > 
> > > > I agree. Who would be responsible for updating the changelog. I'm not
> > > > familiar with that process yet. To be honest, I wouldn't mind having
> > > > the changelog notice in your writing style. Guess would be better for
> > > > everyone ;).  
> > > 
> > > Just a one-liner once we have the 2.12 changelog page.
> > >   
> > > > 
> > > > There are also other things we identified as TODOs:
> > > > * Updating https://wiki.qemu.org/Features/Channel_I/O_Passthrough
> > > > (@Dong Jia, could you take this one)  
> > Ok. Will do soon.
> >   
> > > > * In tree and/or on wiki documentation which is up-to-date and
> > > > more verbose than commit messages are supposed to be (and Dong
> > > > Jia's write-up could be incorporated to). I see this one as
> > > > lower prio though. Any volunteers?  
> > > 
> > > Long-ish things with links etc. should probably go into the wiki.
> > > 
> > > Anyway, feel free to go ahead (it's a wiki :) We can always change
> > > things later on.
> > >   
> > Let me update the wiki based on my understanding (and style :) firstly,
> > then you can login and improve it as you wish.  
> The following wiki is just updated. Please feel free to make additional
> correction:
> https://wiki.qemu.org/Features/Channel_I/O_Passthrough

Looks good, fixed minor typos.

> 
> BTW, Conny mentioned before that we should also update this one:
> https://wiki.qemu.org/Features/LegacyRemoval
> 
> Should it be done now?

Already done :)