From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: Don't acquire AioContext in hmp_qemu_io()
Date: Wed, 13 Dec 2017 10:26:14 +0000 [thread overview]
Message-ID: <20171213102614.GF16782@stefanha-x1.localdomain> (raw)
In-Reply-To: <20171212134800.21836-1-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
On Tue, Dec 12, 2017 at 02:48:00PM +0100, Kevin Wolf wrote:
> Commit 15afd94a047 added code to acquire and release the AioContext in
> qemuio_command(). This means that the lock is taken twice now in the
> call path from hmp_qemu_io(). This causes BDRV_POLL_WHILE() to hang for
> any requests issued to nodes in a non-mainloop AioContext.
>
> Dropping the first locking from hmp_qemu_io() fixes the problem.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hmp.c | 6 ------
> 1 file changed, 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-12-13 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 13:48 [Qemu-devel] [PATCH] block: Don't acquire AioContext in hmp_qemu_io() Kevin Wolf
2017-12-13 10:26 ` Stefan Hajnoczi [this message]
2017-12-13 10:41 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213102614.GF16782@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).