From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Alistair Francis" <alistair.francis@xilinx.com>,
"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
"Prasad J Pandit" <pjp@fedoraproject.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Michael Walle" <michael@walle.cc>,
"Cédric Le Goater" <clg@kaod.org>,
"Andrzej Zaborowski" <balrogg@gmail.com>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Andrey Yurovsky" <yurovsky@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Sai Pavan Boddu" <saipava@xilinx.com>,
"Fam Zheng" <famz@redhat.com>
Subject: [Qemu-devel] [PATCH 00/14] SDHCI housekeeping
Date: Wed, 13 Dec 2017 16:58:38 -0300 [thread overview]
Message-ID: <20171213195852.30439-1-f4bug@amsat.org> (raw)
Hi,
This series refactor the SDHCI codebase to ease further development/series.
- 1: we restrict part of "sd/sd.h" into local "sd-internal.h",
- 2-5,13: we somehow beautiful the code, no logical changes,
- 6-9: we refactor the common sysbus/pci qdev code,
- 10-12: we add plenty of trace events which will result useful later,
- 14: we finally expose a "dma-memory" property.
Regards,
Phil.
Based-on: 20171213051736.17755-5-f4bug@amsat.org
(Trivial changes in "registerfields.h")
Philippe Mathieu-Daudé (14):
sd: split "sd-internal.h" of "hw/sd/sd.h"
sdhci: clean up includes
sdhci: use the ldst_le_dma API
sdhci: use deposit64()
sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h"
sdhci: refactor same sysbus/pci properties into a common one
sdhci: refactor common sysbus/pci realize() into sdhci_realizefn()
sdhci: refactor common sysbus/pci class_init() into sdhci_class_init()
sdhci: refactor common sysbus/pci unrealize() into sdhci_unrealizefn()
sdhci: use qemu_log_mask(UNIMP) instead of fprintf()
sdhci: convert the DPRINT() calls into trace events
sdhci: add a trace event for the LED control
sdhci: add sdhci_init_capareg() to initialize the CAPAB register
sdhci: add a "dma-memory" property
include/hw/sd/sd.h | 95 ++-----------------
include/hw/sd/sdhci.h | 6 +-
hw/sd/sd-internal.h | 119 +++++++++++++++++++++++
hw/sd/sdhci-internal.h | 5 +-
hw/sd/core.c | 3 +-
hw/sd/milkymist-memcard.c | 2 +-
hw/sd/omap_mmc.c | 1 +
hw/sd/pl181.c | 2 +-
hw/sd/pxa2xx_mmci.c | 1 +
hw/sd/sd.c | 6 +-
hw/sd/sdhci.c | 235 ++++++++++++++++++++++++----------------------
hw/sd/ssi-sd.c | 2 +-
hw/sd/trace-events | 15 +++
13 files changed, 276 insertions(+), 216 deletions(-)
create mode 100644 hw/sd/sd-internal.h
--
2.15.1
next reply other threads:[~2017-12-13 19:59 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 19:58 Philippe Mathieu-Daudé [this message]
2017-12-13 19:58 ` [Qemu-devel] [PATCH 01/14] sd: split "sd-internal.h" of "hw/sd/sd.h" Philippe Mathieu-Daudé
2017-12-14 17:50 ` Alistair Francis
2017-12-14 17:59 ` Philippe Mathieu-Daudé
2017-12-14 19:33 ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 02/14] sdhci: clean up includes Philippe Mathieu-Daudé
2017-12-14 17:17 ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 03/14] sdhci: use the ldst_le_dma() API Philippe Mathieu-Daudé
2017-12-14 17:23 ` Alistair Francis
2017-12-14 23:21 ` Philippe Mathieu-Daudé
2017-12-14 23:25 ` Alistair Francis
2017-12-15 0:38 ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 04/14] sdhci: use deposit64() Philippe Mathieu-Daudé
2017-12-14 17:28 ` Alistair Francis
2017-12-14 23:25 ` Philippe Mathieu-Daudé
2017-12-14 23:41 ` Alistair Francis
2017-12-15 0:07 ` Philippe Mathieu-Daudé
2017-12-15 1:14 ` Alistair Francis
2017-12-15 1:51 ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 05/14] sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h" Philippe Mathieu-Daudé
2017-12-14 17:29 ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one Philippe Mathieu-Daudé
2017-12-14 17:32 ` Alistair Francis
2017-12-14 18:40 ` Philippe Mathieu-Daudé
2017-12-14 19:36 ` Alistair Francis
2017-12-15 4:42 ` Kevin O'Connor
2017-12-15 8:10 ` Paolo Bonzini
2017-12-13 19:58 ` [Qemu-devel] [PATCH 07/14] sdhci: refactor common sysbus/pci realize() into sdhci_realizefn() Philippe Mathieu-Daudé
2017-12-14 17:42 ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 08/14] sdhci: refactor common sysbus/pci class_init() into sdhci_class_init() Philippe Mathieu-Daudé
2017-12-14 17:44 ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 09/14] sdhci: refactor common sysbus/pci unrealize() into sdhci_unrealizefn() Philippe Mathieu-Daudé
2017-12-14 17:46 ` Alistair Francis
2017-12-14 18:07 ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 10/14] sdhci: use qemu_log_mask(UNIMP) instead of fprintf() Philippe Mathieu-Daudé
2017-12-14 17:47 ` Alistair Francis
2017-12-14 18:14 ` Philippe Mathieu-Daudé
2017-12-14 19:38 ` Alistair Francis
2017-12-13 19:58 ` [Qemu-devel] [PATCH 11/14] sdhci: convert the DPRINT() calls into trace events Philippe Mathieu-Daudé
2017-12-14 17:54 ` Alistair Francis
2017-12-14 18:19 ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 12/14] sdhci: add a trace event for the LED control Philippe Mathieu-Daudé
2017-12-14 17:55 ` Alistair Francis
2017-12-14 23:32 ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 13/14] sdhci: add sdhci_init_capareg() to initialize the CAPAB register Philippe Mathieu-Daudé
2017-12-14 17:51 ` Alistair Francis
2017-12-14 18:02 ` Philippe Mathieu-Daudé
2017-12-13 19:58 ` [Qemu-devel] [PATCH 14/14] sdhci: add a "dma-memory" property Philippe Mathieu-Daudé
2017-12-14 17:49 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213195852.30439-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=alistair.francis@xilinx.com \
--cc=andrew.smirnov@gmail.com \
--cc=balrogg@gmail.com \
--cc=clg@kaod.org \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=famz@redhat.com \
--cc=michael@walle.cc \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=saipava@xilinx.com \
--cc=yurovsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).