From: Stefan Hajnoczi <stefanha@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, kwolf@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] blockjob: kick jobs on set-speed
Date: Thu, 14 Dec 2017 09:42:59 +0000 [thread overview]
Message-ID: <20171214094259.GB14433@stefanha-x1.localdomain> (raw)
In-Reply-To: <20171213204611.26276-1-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
On Wed, Dec 13, 2017 at 03:46:11PM -0500, John Snow wrote:
> If users set an unreasonably low speed (like one byte per second), the
> calculated delay may exceed many hours. While we like to punish users
> for asking for stupid things, we do also like to allow users to correct
> their wicked ways.
>
> When a user provides a new speed, kick the job to allow it to recalculate
> its delay.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>
> RFC: Why is block_job_mutex shared between all jobs,
> instead of being per-job?
>
> blockjob.c | 30 +++++++++++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-12-14 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 20:46 [Qemu-devel] [PATCH v2] blockjob: kick jobs on set-speed John Snow
2017-12-13 21:19 ` Paolo Bonzini
2017-12-14 9:42 ` Stefan Hajnoczi [this message]
2017-12-14 20:58 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214094259.GB14433@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).