From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePTZE-0001Dn-Sb for qemu-devel@nongnu.org; Thu, 14 Dec 2017 08:28:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePTZB-0003pO-OM for qemu-devel@nongnu.org; Thu, 14 Dec 2017 08:28:52 -0500 Date: Thu, 14 Dec 2017 14:28:42 +0100 From: Cornelia Huck Message-ID: <20171214142842.47ac7e8f.cohuck@redhat.com> In-Reply-To: References: <20171211122146.162430-1-borntraeger@de.ibm.com> <20171214142138.3a5c9eef.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: Christian Borntraeger , qemu-devel , qemu-s390x , Halil Pasic , Alexander Graf , Thomas Huth , Richard Henderson On Thu, 14 Dec 2017 14:26:17 +0100 David Hildenbrand wrote: > On 14.12.2017 14:21, Cornelia Huck wrote: > > On Mon, 11 Dec 2017 13:21:46 +0100 > > Christian Borntraeger wrote: > > > >> KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically > >> limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must > >> be a multiple of 1MB we need start a new memory region if we cross > >> 8TB-1M. > >> > >> With that (and optimistic overcommitment in the kernel) I was able to > >> start a 24TB guest on a 1TB system. > >> > >> Signed-off-by: Christian Borntraeger > >> --- > >> hw/s390x/s390-virtio-ccw.c | 28 +++++++++++++++++++++++++--- > >> 1 file changed, 25 insertions(+), 3 deletions(-) > > > > Thanks, applied (with 1UL -> 1ULL). > > > > Can you add my > > Reviewed-by: David Hildenbrand > > ? > Should be already in there :)