From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: qemu-arm@nongnu.org
Cc: "Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, yurovsky@gmail.com
Subject: [Qemu-devel] [PATCH v2 11/15] imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file
Date: Thu, 14 Dec 2017 06:52:51 -0800 [thread overview]
Message-ID: <20171214145255.31545-12-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20171214145255.31545-1-andrew.smirnov@gmail.com>
Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset
0x614, so to avoid getting aborts when accessing those on QEMU, extend
the register file to cover FSL_IMX25_FEC_SIZE(16K) of address space
instead of just 1K.
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org
Cc: yurovsky@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
hw/net/imx_fec.c | 2 +-
include/hw/arm/fsl-imx25.h | 1 -
include/hw/net/imx_fec.h | 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
index c1cf7f9c58..4fb48f62ba 100644
--- a/hw/net/imx_fec.c
+++ b/hw/net/imx_fec.c
@@ -1281,7 +1281,7 @@ static void imx_eth_realize(DeviceState *dev, Error **errp)
SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
memory_region_init_io(&s->iomem, OBJECT(dev), &imx_eth_ops, s,
- TYPE_IMX_FEC, 0x400);
+ TYPE_IMX_FEC, FSL_IMX25_FEC_SIZE);
sysbus_init_mmio(sbd, &s->iomem);
sysbus_init_irq(sbd, &s->irq[0]);
sysbus_init_irq(sbd, &s->irq[1]);
diff --git a/include/hw/arm/fsl-imx25.h b/include/hw/arm/fsl-imx25.h
index d0e8e9d956..65a73714ef 100644
--- a/include/hw/arm/fsl-imx25.h
+++ b/include/hw/arm/fsl-imx25.h
@@ -192,7 +192,6 @@ typedef struct FslIMX25State {
#define FSL_IMX25_UART5_ADDR 0x5002C000
#define FSL_IMX25_UART5_SIZE 0x4000
#define FSL_IMX25_FEC_ADDR 0x50038000
-#define FSL_IMX25_FEC_SIZE 0x4000
#define FSL_IMX25_CCM_ADDR 0x53F80000
#define FSL_IMX25_CCM_SIZE 0x4000
#define FSL_IMX25_GPT4_ADDR 0x53F84000
diff --git a/include/hw/net/imx_fec.h b/include/hw/net/imx_fec.h
index 91ef8f89a6..7b3faa4019 100644
--- a/include/hw/net/imx_fec.h
+++ b/include/hw/net/imx_fec.h
@@ -245,6 +245,7 @@ typedef struct {
#define ENET_TX_RING_NUM 3
+#define FSL_IMX25_FEC_SIZE 0x4000
typedef struct IMXFECState {
/*< private >*/
--
2.14.3
next prev parent reply other threads:[~2017-12-14 14:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 14:52 [Qemu-devel] [PATCH v2 00/15] i.MX FEC and SD changes Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 01/15] imx_fec: Do not link to netdev Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 02/15] imx_fec: Refactor imx_eth_enable_rx() Andrey Smirnov
2017-12-15 10:06 ` Philippe Mathieu-Daudé
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 03/15] imx_fec: Change queue flushing heuristics Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 04/15] imx_fec: Move Tx frame buffer away from the stack Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 05/15] imx_fec: Use ENET_FTRL to determine truncation length Andrey Smirnov
2017-12-15 10:15 ` Philippe Mathieu-Daudé
2017-12-17 0:41 ` Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 06/15] imx_fec: Use MIN instead of explicit ternary operator Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 07/15] imx_fec: Emulate SHIFT16 in ENETx_RACC Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 08/15] imx_fec: Add support for multiple Tx DMA rings Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 09/15] imx_fec: Use correct length for packet size Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 10/15] imx_fec: Fix a typo in imx_enet_receive() Andrey Smirnov
2017-12-14 14:52 ` Andrey Smirnov [this message]
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 12/15] sdhci: Add i.MX specific subtype of SDHCI Andrey Smirnov
2017-12-15 2:31 ` Philippe Mathieu-Daudé
2017-12-15 18:51 ` Andrey Smirnov
2017-12-15 20:15 ` Philippe Mathieu-Daudé
2017-12-17 0:21 ` Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 13/15] hw: i.MX: Convert i.MX6 to use TYPE_IMX_USDHC Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 14/15] sd: Check for READ_MULTIPLE_BLOCK size limit violation first Andrey Smirnov
2017-12-14 16:45 ` Andrey Smirnov
2017-12-14 14:52 ` [Qemu-devel] [PATCH v2 15/15] sdhci: Implement write method of ACMD12ERRSTS register Andrey Smirnov
2017-12-15 2:18 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214145255.31545-12-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=f4bug@amsat.org \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yurovsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).