From: Cornelia Huck <cohuck@redhat.com>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, rth@twiddle.net,
agraf@suse.de, thuth@redhat.com, borntraeger@de.ibm.com,
david@redhat.com, Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PULL 41/46] s390x/tcg: Implement STORE CHANNEL PATH STATUS
Date: Thu, 14 Dec 2017 18:09:59 +0100 [thread overview]
Message-ID: <20171214171004.25058-42-cohuck@redhat.com> (raw)
In-Reply-To: <20171214171004.25058-1-cohuck@redhat.com>
From: David Hildenbrand <david@redhat.com>
Just like KVM does, we should suppress this instruction:
When this instruction is not provided, it is
checked for privileged operation exception and the
instruction is suppressed by the machine
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20171208160207.26494-11-david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
target/s390x/insn-data.def | 1 +
target/s390x/translate.c | 7 +++++++
2 files changed, 8 insertions(+)
diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def
index 0c225d5e78..2e47a6b5bc 100644
--- a/target/s390x/insn-data.def
+++ b/target/s390x/insn-data.def
@@ -1056,6 +1056,7 @@
C(0xb238, RSCH, S, Z, 0, 0, 0, 0, rsch, 0)
C(0xb237, SAL, S, Z, 0, 0, 0, 0, sal, 0)
C(0xb23c, SCHM, S, Z, 0, insn, 0, 0, schm, 0)
+ C(0xb23a, STCPS, S, Z, 0, 0, 0, 0, stcps, 0)
C(0xb233, SSCH, S, Z, 0, insn, 0, 0, ssch, 0)
C(0xb239, STCRW, S, Z, 0, insn, 0, 0, stcrw, 0)
C(0xb234, STSCH, S, Z, 0, insn, 0, 0, stsch, 0)
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 8cf35a7b49..16febf4274 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -4132,6 +4132,13 @@ static ExitStatus op_schm(DisasContext *s, DisasOps *o)
return NO_EXIT;
}
+static ExitStatus op_stcps(DisasContext *s, DisasOps *o)
+{
+ check_privileged(s);
+ /* The instruction is suppressed if not provided. */
+ return NO_EXIT;
+}
+
static ExitStatus op_ssch(DisasContext *s, DisasOps *o)
{
check_privileged(s);
--
2.13.6
next prev parent reply other threads:[~2017-12-14 17:13 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 17:09 [Qemu-devel] [PULL 00/46] First batch of s390x patches for 2.12 Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 01/46] s390x/migration: use zero flag parameter Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 02/46] pc-bios/s390-ccw: zero out bss section Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 03/46] pc-bios/s390-ccw.img: update image Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 04/46] s390x: introduce 2.12 compat machine Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 05/46] target/s390x: nuke DPRINTF in helper.c Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 06/46] s390x/tcg: introduce and use s390_program_interrupt() Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 07/46] s390x/tcg: get rid of runtime_exception() Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 08/46] s390x/tcg: rip out dead tpi code Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 09/46] s390x/ioinst: pass the retaddr to all IO instructions Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 10/46] s390x/pci: pass the retaddr to all PCI instructions Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 11/46] s390x/diag: pass the retaddr into handle_diag_308() Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 12/46] s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG) Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 13/46] s390x/tcg: don't exit the cpu loop in s390_cpu_virt_mem_rw() Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 14/46] s390x/tcg: io instructions don't need potential_page_fault() Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 15/46] s390x/tcg: use s390_program_interrupt() in SCLP Service Call Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 16/46] s390x/tcg: use s390_program_interrupt() in DIAG Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 17/46] s390x/tcg: use s390_program_interrupt() in per_check_exception() Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 18/46] s390x/tcg: use s390_program_interrupt() in SACF Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 19/46] s390x/tcg: use s390_program_interrupt() in STSI Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 20/46] s390x/tcg: drop program_interrupt() Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 21/46] s390x/tcg: drop potential_page_fault() Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 22/46] s390x/pci: factor out endianess conversion Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 23/46] s390x/pci: rework PCI STORE Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 24/46] s390x/pci: rework PCI LOAD Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 25/46] s390x/pci: rework PCI STORE BLOCK Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 26/46] s390x/pci: move the memory region read from pcilg Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 27/46] s390x/pci: move the memory region write from pcistg Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 28/46] s390x/pci: search for subregion inside the BARs Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 29/46] s390x/css: unrestrict cssids Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 30/46] s390x: deprecate s390-squash-mcss machine prop Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 31/46] s390x/css: attach css bridge Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 32/46] s390x/kvm: factor out build_channel_report_mcic() into cpu.h Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 33/46] s390x/tcg: fix and cleanup mcck injection Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 34/46] s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 35/46] s390x/tcg: indicate value of TODPR in STCKE Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 36/46] s390x/tcg: wire up STORE CHANNEL REPORT WORD Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 37/46] s390x/tcg: ASI/ASGI/ALSI/ALSGI are atomic with Interlocked-acccess facility 1 Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 38/46] s390x/tcg: implement Interlocked-Access Facility 2 Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 39/46] s390x/tcg: wire up SET ADDRESS LIMIT Cornelia Huck
2017-12-14 17:09 ` [Qemu-devel] [PULL 40/46] s390x/tcg: wire up SET CHANNEL MONITOR Cornelia Huck
2017-12-14 17:09 ` Cornelia Huck [this message]
2017-12-14 17:10 ` [Qemu-devel] [PULL 42/46] s390x/tcg: Implement SIGNAL ADAPTER instruction Cornelia Huck
2017-12-14 17:10 ` [Qemu-devel] [PULL 43/46] s390x/tcg: implement extract-CPU-time facility Cornelia Huck
2017-12-14 17:10 ` [Qemu-devel] [PULL 44/46] s390x/tcg: we already implement the Set-Program-Parameter facility Cornelia Huck
2017-12-14 17:10 ` [Qemu-devel] [PULL 45/46] s390x: change the QEMU cpu model to a stripped down z12 Cornelia Huck
2017-12-14 17:10 ` [Qemu-devel] [PULL 46/46] s390-ccw-virtio: allow for systems larger that 7.999TB Cornelia Huck
2017-12-14 19:05 ` [Qemu-devel] [PULL 00/46] First batch of s390x patches for 2.12 Peter Maydell
2017-12-15 8:35 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2017-12-15 9:11 ` Cornelia Huck
2017-12-15 9:51 ` Peter Maydell
2017-12-15 10:21 ` Cornelia Huck
2017-12-15 10:33 ` Peter Maydell
2017-12-15 10:48 ` Cornelia Huck
2017-12-15 9:53 ` David Hildenbrand
2017-12-15 9:53 ` Christian Borntraeger
2017-12-15 10:08 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214171004.25058-42-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).