qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Michael S. Tsirkin" <mst@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-trivial@nongnu.org, "Richard Henderson" <rth@twiddle.net>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Yongbok Kim" <yongbok.kim@mips.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Alexander Graf" <agraf@suse.de>,
	"open list:PReP" <qemu-ppc@nongnu.org>
Subject: [Qemu-devel] [PATCH v4 32/43] hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init()
Date: Fri, 15 Dec 2017 00:30:04 -0300	[thread overview]
Message-ID: <20171215033015.738-33-f4bug@amsat.org> (raw)
In-Reply-To: <20171215033015.738-1-f4bug@amsat.org>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
---
 include/hw/timer/mc146818rtc.h | 3 ++-
 hw/alpha/dp264.c               | 2 +-
 hw/i386/pc.c                   | 2 +-
 hw/isa/i82378.c                | 3 ++-
 hw/mips/mips_fulong2e.c        | 2 +-
 hw/mips/mips_jazz.c            | 2 +-
 hw/mips/mips_malta.c           | 2 +-
 hw/mips/mips_r4k.c             | 2 +-
 hw/ppc/pnv.c                   | 2 +-
 hw/timer/mc146818rtc.c         | 2 +-
 10 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/include/hw/timer/mc146818rtc.h b/include/hw/timer/mc146818rtc.h
index 7c8e64b203..fe6ed63f71 100644
--- a/include/hw/timer/mc146818rtc.h
+++ b/include/hw/timer/mc146818rtc.h
@@ -6,7 +6,8 @@
 
 #define TYPE_MC146818_RTC "mc146818rtc"
 
-ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq);
+ISADevice *mc146818_rtc_init(ISABus *bus, int base_year,
+                             qemu_irq intercept_irq);
 void rtc_set_memory(ISADevice *dev, int addr, int val);
 int rtc_get_memory(ISADevice *dev, int addr);
 
diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
index 887a7401f1..766373eec7 100644
--- a/hw/alpha/dp264.c
+++ b/hw/alpha/dp264.c
@@ -78,7 +78,7 @@ static void clipper_init(MachineState *machine)
                            clipper_pci_map_irq);
 
     /* Since we have an SRM-compatible PALcode, use the SRM epoch.  */
-    rtc_init(isa_bus, 1900, rtc_irq);
+    mc146818_rtc_init(isa_bus, 1900, rtc_irq);
 
     i8254_pit_init(isa_bus, 0x40, 0, NULL);
     isa_create_simple(isa_bus, "i8042");
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 6a6041573f..fe5e8b53bb 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1565,7 +1565,7 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
             rtc_irq = qdev_get_gpio_in(hpet, HPET_LEGACY_RTC_INT);
         }
     }
-    *rtc_state = rtc_init(isa_bus, 2000, rtc_irq);
+    *rtc_state = mc146818_rtc_init(isa_bus, 2000, rtc_irq);
 
     qemu_register_boot_set(pc_boot_set, *rtc_state);
 
diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
index a9c15f858d..a5d67bc6d7 100644
--- a/hw/isa/i82378.c
+++ b/hw/isa/i82378.c
@@ -21,6 +21,7 @@
 #include "hw/pci/pci.h"
 #include "hw/i386/pc.h"
 #include "hw/timer/i8254.h"
+#include "hw/timer/mc146818rtc.h"
 #include "hw/audio/pcspk.h"
 
 #define TYPE_I82378 "i82378"
@@ -106,7 +107,7 @@ static void i82378_realize(PCIDevice *pci, Error **errp)
     isa = isa_create_simple(isabus, "i82374");
 
     /* timer */
-    isa_create_simple(isabus, "mc146818rtc");
+    isa_create_simple(isabus, TYPE_MC146818_RTC);
 }
 
 static void i82378_init(Object *obj)
diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
index 2a2a09c9de..725e25a134 100644
--- a/hw/mips/mips_fulong2e.c
+++ b/hw/mips/mips_fulong2e.c
@@ -365,7 +365,7 @@ static void mips_fulong2e_init(MachineState *machine)
     /* Super I/O */
     isa_create_simple(isa_bus, "i8042");
 
-    rtc_init(isa_bus, 2000, NULL);
+    mc146818_rtc_init(isa_bus, 2000, NULL);
 
     serial_hds_isa_init(isa_bus, 0, MAX_SERIAL_PORTS);
     parallel_hds_isa_init(isa_bus, 1);
diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c
index 995419344d..22a3d5169c 100644
--- a/hw/mips/mips_jazz.c
+++ b/hw/mips/mips_jazz.c
@@ -288,7 +288,7 @@ static void mips_jazz_init(MachineState *machine,
     fdctrl_init_sysbus(qdev_get_gpio_in(rc4030, 1), -1, 0x80003000, fds);
 
     /* Real time clock */
-    rtc_init(isa_bus, 1980, NULL);
+    mc146818_rtc_init(isa_bus, 1980, NULL);
     memory_region_init_io(rtc, NULL, &rtc_ops, NULL, "rtc", 0x1000);
     memory_region_add_subregion(address_space, 0x80004000, rtc);
 
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index 88b4733743..37f19428d6 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -1214,7 +1214,7 @@ void mips_malta_init(MachineState *machine)
     /* Super I/O */
     isa_create_simple(isa_bus, "i8042");
 
-    rtc_init(isa_bus, 2000, NULL);
+    mc146818_rtc_init(isa_bus, 2000, NULL);
     serial_hds_isa_init(isa_bus, 0, 2);
     parallel_hds_isa_init(isa_bus, 1);
 
diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
index 58d7bac18b..9884ee7e9f 100644
--- a/hw/mips/mips_r4k.c
+++ b/hw/mips/mips_r4k.c
@@ -270,7 +270,7 @@ void mips_r4k_init(MachineState *machine)
     i8259 = i8259_init(isa_bus, env->irq[2]);
     isa_bus_irqs(isa_bus, i8259);
 
-    rtc_init(isa_bus, 2000, NULL);
+    mc146818_rtc_init(isa_bus, 2000, NULL);
 
     pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);
 
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index c35c439d81..94ffc8e137 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -655,7 +655,7 @@ static void ppc_powernv_init(MachineState *machine)
     serial_hds_isa_init(pnv->isa_bus, 0, MAX_SERIAL_PORTS);
 
     /* Create an RTC ISA device too */
-    rtc_init(pnv->isa_bus, 2000, NULL);
+    mc146818_rtc_init(pnv->isa_bus, 2000, NULL);
 
     /* OpenPOWER systems use a IPMI SEL Event message to notify the
      * host to powerdown */
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 7764be25ec..35a05a64cc 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -999,7 +999,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
     qdev_init_gpio_out(dev, &s->irq, 1);
 }
 
-ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)
+ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)
 {
     DeviceState *dev;
     ISADevice *isadev;
-- 
2.15.1

  parent reply	other threads:[~2017-12-15  3:32 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15  3:29 [Qemu-devel] [PATCH v4 00/43] remove i386/pc dependency from non-PC world (part 1) Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 01/43] MAINTAINERS: add entries for i2c/ppc4xx Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 02/43] MAINTAINERS: add an entry for the i82374 (southbridge) Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 03/43] MAINTAINERS: add an entry for the i8257 (DMA controller) Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 04/43] MAINTAINERS: add an entry for the i82378 (superio) Philippe Mathieu-Daudé
2017-12-15 10:17   ` Thomas Huth
2017-12-15 10:23     ` Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 05/43] MAINTAINERS: add an entry for watchdog/wdt_ib700 Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 06/43] MAINTAINERS: add an entry for input/pckbd.c Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 07/43] MAINTAINERS: add entries for timer/m48t59 Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 08/43] MAINTAINERS: add missing entry for include/hw/net/ Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 09/43] hw: use "qemu/osdep.h" as first #include in source files Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 10/43] hw: remove "qemu/osdep.h" from header files Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 11/43] block: remove "qemu/osdep.h" from header file Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 12/43] misc: remove headers implicitly included Philippe Mathieu-Daudé
2017-12-15  7:40   ` Ben Warren
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 13/43] misc: remove duplicated includes Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 14/43] ppc: " Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 15/43] i386/hax: " Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 16/43] i386/hax: remove duplicated include Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 17/43] nios2: remove duplicated includes (in code commented out) Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 18/43] misc: avoid "include/" in include path Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 19/43] numa: remove unused #include Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 20/43] hw/input/vmmouse: " Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 21/43] hw/misc/pvpanic: " Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 22/43] hw/ssi/aspeed_smc: " Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 23/43] amd_iommu: avoid needless includes in header file Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 24/43] misc: remove old i386 dependency Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 25/43] hw/ide: " Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 26/43] hw/ipmi: " Philippe Mathieu-Daudé
2017-12-15  3:29 ` [Qemu-devel] [PATCH v4 27/43] hw/i2c: " Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 28/43] hw/tpm: " Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 29/43] hw/virtio-balloon: " Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 30/43] hw/unicore32: restrict hw addr defines to source file Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 31/43] hw/timer/i8254: rename pit_init() -> i8254_pit_init() Philippe Mathieu-Daudé
2017-12-15  3:30 ` Philippe Mathieu-Daudé [this message]
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 33/43] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 34/43] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 35/43] hw/display/vga: "vga.h" only contains registers defs, rename it "vga_regs.h" Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 36/43] hw/display/vga: "vga_int.h" requires "ui/console.h" Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 37/43] hw/display/vga: extract public API from i386/pc to "hw/display/vga.h" Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 38/43] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 39/43] hw/misc/pvpanic: extract public API from i386/pc to "hw/misc/pvpanic.h" Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 40/43] i386/pc: move vmport.c to hw/i386/ Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 41/43] i386/pc: move vmmouse.c " Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 42/43] hw/i386/vmport: replace fprintf() by trace events Philippe Mathieu-Daudé
2017-12-15  3:37   ` Philippe Mathieu-Daudé
2017-12-15  3:30 ` [Qemu-devel] [PATCH v4 43/43] misc: drop old i386 dependency Philippe Mathieu-Daudé
2017-12-15  4:18 ` [Qemu-devel] [PATCH v4 00/43] remove i386/pc dependency from non-PC world (part 1) no-reply
2017-12-15  4:27 ` no-reply
2017-12-15 13:47   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215033015.738-33-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    --cc=yongbok.kim@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).