From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePl6J-0001zw-24 for qemu-devel@nongnu.org; Fri, 15 Dec 2017 03:12:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePl6F-0005rT-2R for qemu-devel@nongnu.org; Fri, 15 Dec 2017 03:12:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55806) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ePl6E-0005rC-S3 for qemu-devel@nongnu.org; Fri, 15 Dec 2017 03:12:07 -0500 Date: Fri, 15 Dec 2017 16:11:41 +0800 From: Peter Xu Message-ID: <20171215081141.GN7780@xz-mi> References: <20171205055200.16305-1-peterx@redhat.com> <20171205055200.16305-8-peterx@redhat.com> <20171213154806.GH7173@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171213154806.GH7173@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [RFC v5 07/26] monitor: unify global init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , "Daniel P . Berrange" , Paolo Bonzini , Fam Zheng , Juan Quintela , mdroth@linux.vnet.ibm.com, Eric Blake , Laurent Vivier , Markus Armbruster , marcandre.lureau@redhat.com, "Dr . David Alan Gilbert" On Wed, Dec 13, 2017 at 03:48:06PM +0000, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:41PM +0800, Peter Xu wrote: > > diff --git a/vl.c b/vl.c > > index 1ad1c04637..1ec995a6ae 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -3144,7 +3144,6 @@ int main(int argc, char **argv, char **envp) > > qemu_init_exec_dir(argv[0]); > > > > module_call_init(MODULE_INIT_QOM); > > - monitor_init_qmp_commands(); > > > > qemu_add_opts(&qemu_drive_opts); > > qemu_add_drive_opts(&qemu_legacy_drive_opts); > > @@ -4690,6 +4689,8 @@ int main(int argc, char **argv, char **envp) > > default_drive(default_floppy, snapshot, IF_FLOPPY, 0, FD_OPTS); > > default_drive(default_sdcard, snapshot, IF_SD, 0, SD_OPTS); > > > > + monitor_init_globals(); > > Why did you move monitor_init_qmp_commands() down here? > > There are many function calls between the old position and the new > position. Did you check all of them to make sure they don't touch the > monitor which is now totally uninitialized? Yeh, this patch is a bit hairy, but I really think we should do it. Because there are too many places (as you have seen) that we inited monitor stuff in different places. IMHO monitor_init_qmp_commands() should be safe to be called here since it only do registration of commands, and AFAICT those commands won't be touched until we init any of the monitors below monitor_init_globals(): if (qemu_opts_foreach(qemu_find_opts("mon"), mon_init_func, NULL, NULL)) { exit(1); } Similar things to other stuff in monitor_init_globals(). They just won't be touched up (correct me if not) until this mon_init_func(). Thanks, -- Peter Xu