qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: mst@redhat.com
Cc: thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 4/4] tests/pxe-test: Add some extra tests
Date: Fri, 15 Dec 2017 21:16:51 +1100	[thread overview]
Message-ID: <20171215101651.13911-5-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20171215101651.13911-1-david@gibson.dropbear.id.au>

Previously virtio-net was only tested for ppc64 in "slow" mode.  That
doesn't make much sense since virtio-net is used much more often in
practice than the spapr-vlan device which was tested always.  So, move
virtio-net to always be tested on ppc64.

We had no tests at all for the q35 machine, which doesn't seem wise given
it's increasing prominence.  Add a couple of tests for it, including
testing the newer e1000e adapter.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 tests/pxe-test.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/pxe-test.c b/tests/pxe-test.c
index e7a0610070..16e2520940 100644
--- a/tests/pxe-test.c
+++ b/tests/pxe-test.c
@@ -31,6 +31,8 @@ typedef struct testdef {
 static testdef_t x86_tests[] = {
     { "pc", "e1000" },
     { "pc", "virtio", "-device virtio-net-pci,netdev=" NETNAME },
+    { "q35", "e1000e" },
+    { "q35", "virtio", "-device virtio-net-pci,netdev=" NETNAME },
     { NULL },
 };
 
@@ -44,11 +46,11 @@ static testdef_t x86_tests_slow[] = {
 
 static testdef_t ppc64_tests[] = {
     { "pseries", "spapr-vlan" },
+    { "pseries", "virtio", "-device virtio-net-pci,netdev=" NETNAME },
     { NULL },
 };
 
 static testdef_t ppc64_tests_slow[] = {
-    { "pseries", "virtio", "-device virtio-net-pci,netdev=" NETNAME },
     { "pseries", "e1000" },
     { NULL },
 };
-- 
2.14.3

  parent reply	other threads:[~2017-12-15 10:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 10:16 [Qemu-devel] [PATCH 0/4] Improvements to pxe-test David Gibson
2017-12-15 10:16 ` [Qemu-devel] [PATCH 1/4] tests/pxe-test: Remove unnecessary special case test functions David Gibson
2017-12-15 10:54   ` Thomas Huth
2017-12-15 10:16 ` [Qemu-devel] [PATCH 2/4] tests/pxe-test: Use table of testcases rather than open-coding David Gibson
2017-12-15 11:08   ` Thomas Huth
2017-12-15 12:54     ` David Gibson
2017-12-15 10:16 ` [Qemu-devel] [PATCH 3/4] tests/pxe-test: Test net booting over IPv6 in some cases David Gibson
2017-12-15 11:10   ` Thomas Huth
2017-12-15 12:56     ` David Gibson
2017-12-15 14:15       ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2017-12-15 10:16 ` David Gibson [this message]
2017-12-15 10:51   ` [Qemu-devel] [PATCH 4/4] tests/pxe-test: Add some extra tests Thomas Huth
2017-12-15 12:59     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215101651.13911-5-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).