From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Aurelien Jarno <aurelien@aurel32.net>,
Yongbok Kim <yongbok.kim@mips.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PATCH 10/15] piix4: add a i8042 keyboard/mouse controller as specified in datasheet
Date: Sat, 16 Dec 2017 10:02:23 +0100 [thread overview]
Message-ID: <20171216090228.28505-11-hpoussin@reactos.org> (raw)
In-Reply-To: <20171216090228.28505-1-hpoussin@reactos.org>
Remove i8042 instanciated in malta board, to not have it twice.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/isa/piix4.c | 3 +++
hw/mips/mips_malta.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index c215bee1ff..cf134b01ee 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -165,6 +165,9 @@ static void piix4_realize(PCIDevice *pci, Error **errp)
/* DMA */
DMA_init(isa_bus, 0);
+ /* Super I/O */
+ isa_create_simple(isa_bus, "i8042");
+
piix4_dev = pci;
qemu_register_reset(piix4_reset, s);
}
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index 5a087fa75d..78049ccf86 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -1203,9 +1203,6 @@ void mips_malta_init(MachineState *machine)
smbus_eeprom_init(smbus, 8, smbus_eeprom_buf, smbus_eeprom_size);
g_free(smbus_eeprom_buf);
- /* Super I/O */
- isa_create_simple(isa_bus, "i8042");
-
rtc_init(isa_bus, 2000, NULL);
serial_hds_isa_init(isa_bus, 0, 2);
parallel_hds_isa_init(isa_bus, 1);
--
2.11.0
next prev parent reply other threads:[~2017-12-16 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 9:02 [Qemu-devel] [PATCH 00/15] piix4: cleanup and improvements Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 01/15] fdc: move object structures to header file Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 02/15] serial/parallel: " Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 03/15] mc146818rtc: move structure " Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 04/15] mc146818rtc: always register rtc to rtc list Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 05/15] piix4: rename some variables in realize function Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 06/15] piix4: add Reset Control Register Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 07/15] piix4: add a i8259 interrupt controller as specified in datasheet Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 08/15] piix4: add a i8257 dma " Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 09/15] piix4: add a i8254 pit " Hervé Poussineau
2017-12-16 9:02 ` Hervé Poussineau [this message]
2017-12-16 9:02 ` [Qemu-devel] [PATCH 11/15] piix4: add a floppy controller, 1 parallel port and 2 serial ports Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 12/15] piix4: add a mc146818rtc controller as specified in datasheet Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 13/15] piix4: add a speaker " Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 14/15] piix4: rename PIIX4 object to piix4-isa Hervé Poussineau
2017-12-16 9:02 ` [Qemu-devel] [PATCH 15/15] piix4: we can now instanciate a PIIX4 with -device Hervé Poussineau
2017-12-16 9:21 ` [Qemu-devel] [PATCH 00/15] piix4: cleanup and improvements no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216090228.28505-11-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=aurelien@aurel32.net \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yongbok.kim@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).