qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Richard Henderson <rth@twiddle.net>, Alexander Graf <agraf@suse.de>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	Stefan Weil <sw@weilnetz.de>
Subject: [Qemu-devel] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842)
Date: Sun, 17 Dec 2017 11:11:36 +0100	[thread overview]
Message-ID: <20171217101136.20206-1-sw@weilnetz.de> (raw)

This should fix the Coverity warning:

** CID 1383842:  Integer handling issues  (DIVIDE_BY_ZERO)
/target/s390x/int_helper.c: 84 in helper_divs64()

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 target/s390x/cpu.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 1a8b6b9ae9..2a6e75d697 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -746,8 +746,8 @@ void s390_io_interrupt(uint16_t subchannel_id, uint16_t subchannel_nr,
 /* automatically detect the instruction length */
 #define ILEN_AUTO                   0xff
 #define RA_IGNORED                  0
-void s390_program_interrupt(CPUS390XState *env, uint32_t code, int ilen,
-                            uintptr_t ra);
+void QEMU_NORETURN s390_program_interrupt(CPUS390XState *env, uint32_t code,
+                                          int ilen, uintptr_t ra);
 /* service interrupts are floating therefore we must not pass an cpustate */
 void s390_sclp_extint(uint32_t parm);
 
-- 
2.11.0

             reply	other threads:[~2017-12-17 10:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-17 10:11 Stefan Weil [this message]
2017-12-17 10:25 ` [Qemu-devel] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842) no-reply
2017-12-17 10:58   ` Stefan Weil
2017-12-17 17:07     ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2017-12-18  8:00       ` David Hildenbrand
2017-12-18  8:05       ` David Hildenbrand
2017-12-18  8:11         ` Thomas Huth
2017-12-17 10:37 ` [Qemu-devel] " no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171217101136.20206-1-sw@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).