* [Qemu-devel] [PATCH] io: fix QIONetListener memory leak
@ 2017-12-18 8:53 Paolo Bonzini
2017-12-18 9:32 ` Daniel P. Berrange
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2017-12-18 8:53 UTC (permalink / raw)
To: qemu-devel
The sources array does not escape out of qio_net_listener_wait_client, so
we have to free it.
Reported by Coverity.
Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
io/net-listener.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/io/net-listener.c b/io/net-listener.c
index 77a4e2831c..de38dfae99 100644
--- a/io/net-listener.c
+++ b/io/net-listener.c
@@ -234,6 +234,7 @@ QIOChannelSocket *qio_net_listener_wait_client(QIONetListener *listener)
for (i = 0; i < listener->nsioc; i++) {
g_source_unref(sources[i]);
}
+ g_free(sources);
g_main_loop_unref(loop);
g_main_context_unref(ctxt);
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] io: fix QIONetListener memory leak
2017-12-18 8:53 [Qemu-devel] [PATCH] io: fix QIONetListener memory leak Paolo Bonzini
@ 2017-12-18 9:32 ` Daniel P. Berrange
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrange @ 2017-12-18 9:32 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Mon, Dec 18, 2017 at 09:53:08AM +0100, Paolo Bonzini wrote:
> The sources array does not escape out of qio_net_listener_wait_client, so
> we have to free it.
>
> Reported by Coverity.
>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> io/net-listener.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, queued.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-18 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-18 8:53 [Qemu-devel] [PATCH] io: fix QIONetListener memory leak Paolo Bonzini
2017-12-18 9:32 ` Daniel P. Berrange
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).