From: "Daniel P. Berrange" <berrange@redhat.com>
To: Miika S <miika9764@gmail.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] Key code conflict in keycodemapdb
Date: Mon, 18 Dec 2017 10:57:04 +0000 [thread overview]
Message-ID: <20171218105704.GD13493@redhat.com> (raw)
In-Reply-To: <CABMrAhLGAm60AgMjbaKSd3k=oX7J6DVO-DwwW04RE75mEWqhCQ@mail.gmail.com>
On Fri, Dec 15, 2017 at 10:03:31PM +0200, Miika S wrote:
> Ok, I don't know if there is a separate place where to send patches
> for keycodemapdb but I will put it in this reply. I will send a new
> set of patches for the QEMU changes that were in the first mail
> (hopefully in a better format than this one) and also a fix for mouse
> wheel event being sent twice.
keycodemapdb patches can be sent as a pull request to the master upstream
repo https://gitlab.com/keycodemap/keycodemapdb/merge_requests
That said, I watch for patches sent to gtk-vnc/qemu/libvirt/spice-gtk
lists that cover keycodemapdb, so I have applied your patch to the
upstream.
When sending your updated qemu patch, don't forget to include the
keycodemapdb git submodule update to the hash containing your change
05dad417e9d0b37ee1fba33056d91a6b734b3357
You can do this as follows
cd $YOUR-QEMU-CHECKOUT
cd ui/keycodemapdb
git pull
cd ../..
git add ui/keycodemapdb
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2017-12-18 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 13:51 [Qemu-devel] Key code conflict in keycodemapdb Miika S
2017-12-15 13:57 ` Daniel P. Berrange
2017-12-15 20:03 ` Miika S
2017-12-18 10:57 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218105704.GD13493@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=miika9764@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).