From: Eduardo Habkost <ehabkost@redhat.com>
To: Yoni Bettan <ybettan@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Hannes Reinecke <hare@suse.com>,
"open list:nvme" <qemu-block@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Keith Busch <keith.busch@intel.com>,
Dmitry Fleytman <dmitry@daynix.com>,
Paul Burton <paul.burton@mips.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V4] pci: removed the is_express field since a uniform interface was inserted
Date: Mon, 18 Dec 2017 11:23:54 -0200 [thread overview]
Message-ID: <20171218132354.GB31737@localhost.localdomain> (raw)
In-Reply-To: <20171212053649.1109-1-ybettan@redhat.com>
On Tue, Dec 12, 2017 at 07:36:49AM +0200, Yoni Bettan wrote:
> * according to Eduardo Habkost's commit
> fd3b02c8896d597dd8b9e053dec579cf0386aee1
>
> * since all PCIEs now implement INTERFACE_PCIE_DEVICE we
> don't need this field anymore
>
> * Devices that where only INTERFACE_PCIE_DEVICE (is_express == 1)
> or
> devices that where only INTERFACE_CONVENTIONAL_PCI_DEVICE (is_express == 0)
> where not affected by the change
>
> The only devices that were affected are those that are hybrid and also
> had (is_express == 1) - therefor only:
> - hw/vfio/pci.c
> - hw/usb/hcd-xhci.c
Oops, we now have xen-pt too. See:
From: Simon Gaiser <hw42@ipsumj.de>
Date: Sat, 28 Oct 2017 04:53:15 +0200
Message-Id: <20171028025315.13500-1-hw42@ipsumj.de>
Subject: [PATCH] xen/pt: Set is_express to avoid out-of-bounds write
Which was included in a pull request sent on last Thursday.
>
> For both I made sure that QEMU_PCI_CAP_EXPRESS is on
>
> Signed-off-by: Yoni Bettan <ybettan@redhat.com>
[...]
--
Eduardo
prev parent reply other threads:[~2017-12-18 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 5:36 [Qemu-devel] [PATCH V4] pci: removed the is_express field since a uniform interface was inserted Yoni Bettan
2017-12-12 13:30 ` Marcel Apfelbaum
2017-12-18 13:18 ` Eduardo Habkost
2017-12-18 13:23 ` Eduardo Habkost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218132354.GB31737@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=dmitry@daynix.com \
--cc=hare@suse.com \
--cc=jasowang@redhat.com \
--cc=keith.busch@intel.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcel@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=paul.burton@mips.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ybettan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).