From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQvQ1-0003Nl-Ji for qemu-devel@nongnu.org; Mon, 18 Dec 2017 08:25:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQvQ0-0007hC-F0 for qemu-devel@nongnu.org; Mon, 18 Dec 2017 08:25:21 -0500 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:39994) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQvQ0-0007gQ-7Y for qemu-devel@nongnu.org; Mon, 18 Dec 2017 08:25:20 -0500 Received: by mail-lf0-x242.google.com with SMTP id g74so7820248lfk.7 for ; Mon, 18 Dec 2017 05:25:20 -0800 (PST) From: Miika S Date: Mon, 18 Dec 2017 15:24:39 +0200 Message-Id: <20171218132439.2772-3-miika9764@gmail.com> In-Reply-To: <20171218132439.2772-1-miika9764@gmail.com> References: <20171218132439.2772-1-miika9764@gmail.com> Subject: [Qemu-devel] [PATCH 3/3] input: virtio: don't send mouse wheel event twice List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Miika S On Linux, a mouse event is generated for both down and up when mouse wheel is used. This caused virtio_input_send() to be called twice each time the wheel was used. This commit adds a check for the button down state and only calls virtio_input_send() when it is true. Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c index 2cac659469..587616a932 100644 --- a/hw/input/virtio-input-hid.c +++ b/hw/input/virtio-input-hid.c @@ -225,8 +225,10 @@ static void virtio_input_handle_event(DeviceState *dev, QemuConsole *src, break; case INPUT_EVENT_KIND_BTN: btn = evt->u.btn.data; - if (vhid->wheel_axis && (btn->button == INPUT_BUTTON_WHEEL_UP || - btn->button == INPUT_BUTTON_WHEEL_DOWN)) { + if (vhid->wheel_axis && + (btn->button == INPUT_BUTTON_WHEEL_UP || + btn->button == INPUT_BUTTON_WHEEL_DOWN) && + btn->down) { event.type = cpu_to_le16(EV_REL); event.code = cpu_to_le16(REL_WHEEL); event.value = cpu_to_le32(btn->button == INPUT_BUTTON_WHEEL_UP -- 2.15.1