From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 12/13] ucontext: annotate coroutine stack for ASAN
Date: Mon, 18 Dec 2017 13:30:56 +0000 [thread overview]
Message-ID: <20171218133056.GC16653@stefanha-x1.localdomain> (raw)
In-Reply-To: <20171215150659.1811-13-marcandre.lureau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On Fri, Dec 15, 2017 at 04:06:58PM +0100, Marc-André Lureau wrote:
> It helps ASAN to detect more leaks on coroutine stacks, as found in
> the following patch.
>
> A similar work would need to be done for sigaltstack & windows fibers
> to have similar coverage. Since ucontext is prefered, I didn't bother
> checking the other coroutine implementations for now.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/qemu/compiler.h | 4 ++++
> util/coroutine-ucontext.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 50 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-12-18 13:31 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 15:06 [Qemu-devel] [PATCH v2 00/13] Various build-sys and ASAN related fixes Marc-André Lureau
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 01/13] build-sys: fix qemu-ga -pthread linking Marc-André Lureau
2017-12-15 18:21 ` Philippe Mathieu-Daudé
2017-12-15 18:31 ` Peter Maydell
2017-12-19 15:43 ` Marc-André Lureau
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or V=0 Marc-André Lureau
2017-12-19 16:35 ` Eric Blake
2018-01-02 15:49 ` Marc-André Lureau
2018-01-02 17:33 ` Paolo Bonzini
2018-01-02 17:58 ` Marc-André Lureau
2018-01-02 18:02 ` Paolo Bonzini
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 03/13] build-sys: add a rule to print a variable Marc-André Lureau
2017-12-15 18:28 ` Eric Blake
2017-12-19 15:45 ` Marc-André Lureau
2017-12-19 16:31 ` Eric Blake
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 04/13] build-sys: add AddressSanitizer when --enable-debug if possible Marc-André Lureau
2017-12-19 15:48 ` Marc-André Lureau
2018-01-02 15:49 ` Marc-André Lureau
2018-01-02 17:31 ` Paolo Bonzini
2018-01-03 17:52 ` Peter Maydell
2018-01-03 18:02 ` Marc-André Lureau
2018-01-03 18:10 ` Paolo Bonzini
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 05/13] tests: fix check-qobject leak: Marc-André Lureau
2017-12-15 18:17 ` Philippe Mathieu-Daudé
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 06/13] vl: fix direct firmware directories leak Marc-André Lureau
2017-12-15 18:30 ` Eric Blake
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 07/13] readline: add a free function Marc-André Lureau
2017-12-15 18:16 ` Philippe Mathieu-Daudé
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 08/13] tests: fix migration-test leak Marc-André Lureau
2017-12-15 18:08 ` Philippe Mathieu-Daudé
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 09/13] crypto: fix stack-buffer-overflow error Marc-André Lureau
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 10/13] qemu-config: fix leak in query-command-line-options Marc-André Lureau
2017-12-15 18:35 ` Eric Blake
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 11/13] tests: fix qmp-test leak Marc-André Lureau
2017-12-15 18:11 ` Philippe Mathieu-Daudé
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 12/13] ucontext: annotate coroutine stack for ASAN Marc-André Lureau
2017-12-15 18:10 ` Philippe Mathieu-Daudé
2017-12-15 18:39 ` Eric Blake
2017-12-18 13:30 ` Stefan Hajnoczi [this message]
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 13/13] tests: fix coroutine leak in /basic/entered Marc-André Lureau
2017-12-18 13:25 ` Stefan Hajnoczi
2017-12-15 15:22 ` [Qemu-devel] [PATCH v2 00/13] Various build-sys and ASAN related fixes Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218133056.GC16653@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).