From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Namhyung Kim <namhyung@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 2/4] trace: Generalize searching for debugfs
Date: Mon, 18 Dec 2017 14:47:58 +0000 [thread overview]
Message-ID: <20171218144800.27337-3-stefanha@redhat.com> (raw)
In-Reply-To: <20171218144800.27337-1-stefanha@redhat.com>
From: Namhyung Kim <namhyung@gmail.com>
The find_debugfs() can be shared to find a different filesystem like
tracefs. So make it more general and rename to find_mount().
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
trace/ftrace.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/trace/ftrace.c b/trace/ftrace.c
index bfa38e71f0..213cb2205f 100644
--- a/trace/ftrace.c
+++ b/trace/ftrace.c
@@ -15,7 +15,7 @@
int trace_marker_fd;
-static int find_debugfs(char *debugfs)
+static int find_mount(char *mount_point, const char *fstype)
{
char type[100];
FILE *fp;
@@ -27,8 +27,8 @@ static int find_debugfs(char *debugfs)
}
while (fscanf(fp, "%*s %" STR(PATH_MAX) "s %99s %*s %*d %*d\n",
- debugfs, type) == 2) {
- if (strcmp(type, "debugfs") == 0) {
+ mount_point, type) == 2) {
+ if (strcmp(type, fstype) == 0) {
ret = 1;
break;
}
@@ -40,14 +40,14 @@ static int find_debugfs(char *debugfs)
bool ftrace_init(void)
{
- char debugfs[PATH_MAX];
+ char mount_point[PATH_MAX];
char path[PATH_MAX];
int debugfs_found;
int trace_fd = -1;
- debugfs_found = find_debugfs(debugfs);
+ debugfs_found = find_mount(mount_point, "debugfs");
if (debugfs_found) {
- snprintf(path, PATH_MAX, "%s/tracing/tracing_on", debugfs);
+ snprintf(path, PATH_MAX, "%s/tracing/tracing_on", mount_point);
trace_fd = open(path, O_WRONLY);
if (trace_fd < 0) {
if (errno == EACCES) {
@@ -66,7 +66,7 @@ bool ftrace_init(void)
}
close(trace_fd);
}
- snprintf(path, PATH_MAX, "%s/tracing/trace_marker", debugfs);
+ snprintf(path, PATH_MAX, "%s/tracing/trace_marker", mount_point);
trace_marker_fd = open(path, O_WRONLY);
if (trace_marker_fd < 0) {
perror("Could not open ftrace 'trace_marker' file");
--
2.14.3
next prev parent reply other threads:[~2017-12-18 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 14:47 [Qemu-devel] [PULL 0/4] Tracing patches Stefan Hajnoczi
2017-12-18 14:47 ` [Qemu-devel] [PULL 1/4] trace: Simplify find_debugfs() Stefan Hajnoczi
2017-12-18 14:47 ` Stefan Hajnoczi [this message]
2017-12-18 14:47 ` [Qemu-devel] [PULL 3/4] trace: Try using tracefs first Stefan Hajnoczi
2017-12-18 14:48 ` [Qemu-devel] [PULL 4/4] gdbstub: add tracing Stefan Hajnoczi
2017-12-19 12:48 ` [Qemu-devel] [PULL 0/4] Tracing patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218144800.27337-3-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=namhyung@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).