[Qemu-devel] [PATCH] spapr_pci: use warn_report()

[Qemu-devel] [PATCH] spapr_pci: use warn_report()

[Greg Kurz]

These two are definitely warnings. Let's use the appropriate API.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 hw/ppc/spapr_pci.c      |    6 +++---
 hw/ppc/spapr_pci_vfio.c |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 88797b3d3622..695c82091140 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1696,9 +1696,9 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)
     /* DMA setup */
     if (((sphb->page_size_mask & qemu_getrampagesize()) == 0)
         && kvm_enabled()) {
-        error_report("System page size 0x%lx is not enabled in page_size_mask "
-                     "(0x%"PRIx64"). Performance may be slow",
-                     qemu_getrampagesize(), sphb->page_size_mask);
+        warn_report("System page size 0x%lx is not enabled in page_size_mask "
+                    "(0x%"PRIx64"). Performance may be slow",
+                    qemu_getrampagesize(), sphb->page_size_mask);
     }
 
     for (i = 0; i < windows_supported; ++i) {
diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
index 8448e0b0247d..1f775ea93dc6 100644
--- a/hw/ppc/spapr_pci_vfio.c
+++ b/hw/ppc/spapr_pci_vfio.c
@@ -50,7 +50,7 @@ static Property spapr_phb_vfio_properties[] = {
 static void spapr_phb_vfio_instance_init(Object *obj)
 {
     if (!qtest_enabled()) {
-        error_report("spapr-pci-vfio-host-bridge is deprecated");
+        warn_report("spapr-pci-vfio-host-bridge is deprecated");
     }
 }
 

Re: [Qemu-devel] [PATCH] spapr_pci: use warn_report()

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1930 bytes --]

On Mon, Dec 18, 2017 at 04:58:02PM +0100, Greg Kurz wrote:
> These two are definitely warnings. Let's use the appropriate API.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Applied to ppc-for-2.12, thanks.

> ---
>  hw/ppc/spapr_pci.c      |    6 +++---
>  hw/ppc/spapr_pci_vfio.c |    2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index 88797b3d3622..695c82091140 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -1696,9 +1696,9 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)
>      /* DMA setup */
>      if (((sphb->page_size_mask & qemu_getrampagesize()) == 0)
>          && kvm_enabled()) {
> -        error_report("System page size 0x%lx is not enabled in page_size_mask "
> -                     "(0x%"PRIx64"). Performance may be slow",
> -                     qemu_getrampagesize(), sphb->page_size_mask);
> +        warn_report("System page size 0x%lx is not enabled in page_size_mask "
> +                    "(0x%"PRIx64"). Performance may be slow",
> +                    qemu_getrampagesize(), sphb->page_size_mask);
>      }
>  
>      for (i = 0; i < windows_supported; ++i) {
> diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
> index 8448e0b0247d..1f775ea93dc6 100644
> --- a/hw/ppc/spapr_pci_vfio.c
> +++ b/hw/ppc/spapr_pci_vfio.c
> @@ -50,7 +50,7 @@ static Property spapr_phb_vfio_properties[] = {
>  static void spapr_phb_vfio_instance_init(Object *obj)
>  {
>      if (!qtest_enabled()) {
> -        error_report("spapr-pci-vfio-host-bridge is deprecated");
> +        warn_report("spapr-pci-vfio-host-bridge is deprecated");
>      }
>  }
>  
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]