Re: [Qemu-devel] [PATCH v2 01/19] dma-helpers: add a return value to store helpers

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]

On Sat, Dec 09, 2017 at 09:43:20AM +0100, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Hrm.  I know I (indirectly) suggested this, but now that I see it, I'm
thinking adding return values here but not on the read side (which
would be awkward since they return the read values) seems like not a
great idea.

So I'm ok with just open coding the dma_memory_write()s after all.

> ---
>  include/sysemu/dma.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h
> index c228c6651360..74a9558af39c 100644
> --- a/include/sysemu/dma.h
> +++ b/include/sysemu/dma.h
> @@ -153,12 +153,12 @@ static inline void dma_memory_unmap(AddressSpace *as,
>          dma_memory_read(as, addr, &val, (_bits) / 8);                   \
>          return _end##_bits##_to_cpu(val);                               \
>      }                                                                   \
> -    static inline void st##_sname##_##_end##_dma(AddressSpace *as,      \
> +    static inline int st##_sname##_##_end##_dma(AddressSpace *as,      \
>                                                   dma_addr_t addr,       \
>                                                   uint##_bits##_t val)   \
>      {                                                                   \
>          val = cpu_to_##_end##_bits(val);                                \
> -        dma_memory_write(as, addr, &val, (_bits) / 8);                  \
> +        return dma_memory_write(as, addr, &val, (_bits) / 8);           \
>      }
>  
>  static inline uint8_t ldub_dma(AddressSpace *as, dma_addr_t addr)

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]