[Qemu-devel] [PATCH] scripts/make-release: More .git removal

[Qemu-devel] [PATCH] scripts/make-release: More .git removal

[Cole Robinson]

As was last done in 379e21c25, we want to remove .git files for
submodules here, which we aren't presently doing for capstone and
keycodemapdb.

Rather than a whitelist use 'find' to future proof this

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 scripts/make-release | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/make-release b/scripts/make-release
index 3917df7142..7c7bec577f 100755
--- a/scripts/make-release
+++ b/scripts/make-release
@@ -19,7 +19,7 @@ pushd ${destination}
 git checkout "v${version}"
 git submodule update --init
 (cd roms/seabios && git describe --tags --long --dirty > .version)
-rm -rf .git roms/*/.git dtc/.git pixman/.git
+find . -depth -name .git -exec rm -rf '{}' \;
 # FIXME: The following line is a workaround for avoiding filename collisions
 # when unpacking u-boot sources on case-insensitive filesystems. Once we
 # update to something with u-boot commit 610eec7f0 we can drop this line.
-- 
2.14.3

Re: [Qemu-devel] [PATCH] scripts/make-release: More .git removal

[Thomas Huth]

On 18.12.2017 23:33, Cole Robinson wrote:
> As was last done in 379e21c25, we want to remove .git files for
> submodules here, which we aren't presently doing for capstone and
> keycodemapdb.
> 
> Rather than a whitelist use 'find' to future proof this
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  scripts/make-release | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/make-release b/scripts/make-release
> index 3917df7142..7c7bec577f 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -19,7 +19,7 @@ pushd ${destination}
>  git checkout "v${version}"
>  git submodule update --init
>  (cd roms/seabios && git describe --tags --long --dirty > .version)
> -rm -rf .git roms/*/.git dtc/.git pixman/.git
> +find . -depth -name .git -exec rm -rf '{}' \;

Good idea! That also fixes the dead pixman/.git entry :-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH] scripts/make-release: More .git removal

[Daniel P. Berrange]

On Mon, Dec 18, 2017 at 05:33:54PM -0500, Cole Robinson wrote:
> As was last done in 379e21c25, we want to remove .git files for
> submodules here, which we aren't presently doing for capstone and
> keycodemapdb.
> 
> Rather than a whitelist use 'find' to future proof this
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  scripts/make-release | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


> 
> diff --git a/scripts/make-release b/scripts/make-release
> index 3917df7142..7c7bec577f 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -19,7 +19,7 @@ pushd ${destination}
>  git checkout "v${version}"
>  git submodule update --init
>  (cd roms/seabios && git describe --tags --long --dirty > .version)
> -rm -rf .git roms/*/.git dtc/.git pixman/.git
> +find . -depth -name .git -exec rm -rf '{}' \;
>  # FIXME: The following line is a workaround for avoiding filename collisions
>  # when unpacking u-boot sources on case-insensitive filesystems. Once we
>  # update to something with u-boot commit 610eec7f0 we can drop this line.
> -- 
> 2.14.3
> 
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH] scripts/make-release: More .git removal

[Markus Armbruster]

Cole Robinson <crobinso@redhat.com> writes:

> As was last done in 379e21c25, we want to remove .git files for
> submodules here, which we aren't presently doing for capstone and
> keycodemapdb.
>
> Rather than a whitelist use 'find' to future proof this
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  scripts/make-release | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/make-release b/scripts/make-release
> index 3917df7142..7c7bec577f 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -19,7 +19,7 @@ pushd ${destination}
>  git checkout "v${version}"
>  git submodule update --init
>  (cd roms/seabios && git describe --tags --long --dirty > .version)
> -rm -rf .git roms/*/.git dtc/.git pixman/.git
> +find . -depth -name .git -exec rm -rf '{}' \;
>  # FIXME: The following line is a workaround for avoiding filename collisions
>  # when unpacking u-boot sources on case-insensitive filesystems. Once we
>  # update to something with u-boot commit 610eec7f0 we can drop this line.

Less scary: run tar with --exclude=.git.

Re: [Qemu-devel] [PATCH] scripts/make-release: More .git removal

[Cole Robinson]

On 12/19/2017 08:13 AM, Markus Armbruster wrote:
> Cole Robinson <crobinso@redhat.com> writes:
> 
>> As was last done in 379e21c25, we want to remove .git files for
>> submodules here, which we aren't presently doing for capstone and
>> keycodemapdb.
>>
>> Rather than a whitelist use 'find' to future proof this
>>
>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>> ---
>>  scripts/make-release | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/make-release b/scripts/make-release
>> index 3917df7142..7c7bec577f 100755
>> --- a/scripts/make-release
>> +++ b/scripts/make-release
>> @@ -19,7 +19,7 @@ pushd ${destination}
>>  git checkout "v${version}"
>>  git submodule update --init
>>  (cd roms/seabios && git describe --tags --long --dirty > .version)
>> -rm -rf .git roms/*/.git dtc/.git pixman/.git
>> +find . -depth -name .git -exec rm -rf '{}' \;
>>  # FIXME: The following line is a workaround for avoiding filename collisions
>>  # when unpacking u-boot sources on case-insensitive filesystems. Once we
>>  # update to something with u-boot commit 610eec7f0 we can drop this line.
> 
> Less scary: run tar with --exclude=.git.
> 

Good idea, I sent a v2 using that instead

Thanks,
Cole