From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL v2 19/23] docs: mark nested AioContext locking as a legacy API
Date: Tue, 19 Dec 2017 15:11:40 +0000 [thread overview]
Message-ID: <20171219151144.11120-20-stefanha@redhat.com> (raw)
In-Reply-To: <20171219151144.11120-1-stefanha@redhat.com>
See the patch for why nested AioContext locking is no longer allowed.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20171207201320.19284-3-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
docs/devel/multiple-iothreads.txt | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/docs/devel/multiple-iothreads.txt b/docs/devel/multiple-iothreads.txt
index e4d340bbb7..4f9012d154 100644
--- a/docs/devel/multiple-iothreads.txt
+++ b/docs/devel/multiple-iothreads.txt
@@ -1,4 +1,4 @@
-Copyright (c) 2014 Red Hat Inc.
+Copyright (c) 2014-2017 Red Hat Inc.
This work is licensed under the terms of the GNU GPL, version 2 or later. See
the COPYING file in the top-level directory.
@@ -92,8 +92,9 @@ aio_context_acquire()/aio_context_release() for mutual exclusion. Once the
context is acquired no other thread can access it or run event loop iterations
in this AioContext.
-aio_context_acquire()/aio_context_release() calls may be nested. This
-means you can call them if you're not sure whether #2 applies.
+Legacy code sometimes nests aio_context_acquire()/aio_context_release() calls.
+Do not use nesting anymore, it is incompatible with the BDRV_POLL_WHILE() macro
+used in the block layer and can lead to hangs.
There is currently no lock ordering rule if a thread needs to acquire multiple
AioContexts simultaneously. Therefore, it is only safe for code holding the
--
2.14.3
next prev parent reply other threads:[~2017-12-19 15:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 15:11 [Qemu-devel] [PULL v2 00/23] Block patches Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 01/23] coroutine: simplify co_aio_sleep_ns() prototype Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 02/23] hw/block/nvme: Convert to realize Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 03/23] hw/block: Fix the return type Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 04/23] hw/block: Use errp directly rather than local_err Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 05/23] dev-storage: Fix the unusual function name Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 06/23] qdev: drop unused #include "sysemu/iothread.h" Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 07/23] blockdev: hold AioContext for bdrv_unref() in external_snapshot_clean() Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 08/23] block: don't keep AioContext acquired after external_snapshot_prepare() Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 09/23] block: don't keep AioContext acquired after drive_backup_prepare() Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 10/23] block: don't keep AioContext acquired after blockdev_backup_prepare() Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 11/23] block: don't keep AioContext acquired after internal_snapshot_prepare() Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 12/23] block: drop unused BlockDirtyBitmapState->aio_context field Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 13/23] iothread: add iothread_by_id() API Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 14/23] blockdev: add x-blockdev-set-iothread testing command Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 15/23] qemu-iotests: add 202 external snapshots IOThread test Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 16/23] virtio-blk: make queue size configurable Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 17/23] virtio-blk: reject configs with logical block size > physical block size Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 18/23] block: avoid recursive AioContext acquire in bdrv_inactivate_all() Stefan Hajnoczi
2017-12-19 15:11 ` Stefan Hajnoczi [this message]
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 20/23] blockdev: add x-blockdev-set-iothread force boolean Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 21/23] iotests: add VM.add_object() Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 22/23] iothread: fix iothread_stop() race condition Stefan Hajnoczi
2017-12-19 15:11 ` [Qemu-devel] [PULL v2 23/23] qemu-iotests: add 203 savevm with IOThreads test Stefan Hajnoczi
2017-12-20 13:20 ` [Qemu-devel] [PULL v2 00/23] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219151144.11120-20-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).