From: Eduardo Habkost <ehabkost@redhat.com>
To: Yoni Bettan <ybettan@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Hannes Reinecke <hare@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"open list:X86" <xen-devel@lists.xenproject.org>,
"open list:nvme" <qemu-block@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Keith Busch <keith.busch@intel.com>,
Dmitry Fleytman <dmitry@daynix.com>,
Paul Burton <paul.burton@mips.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted
Date: Tue, 19 Dec 2017 14:42:18 -0200 [thread overview]
Message-ID: <20171219164218.GB4836@localhost.localdomain> (raw)
In-Reply-To: <20171218152140.17985-1-ybettan@redhat.com>
On Mon, Dec 18, 2017 at 05:21:40PM +0200, Yoni Bettan wrote:
> according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement
> INTERFACE_PCIE_DEVICE so we don't need is_express field anymore.
>
> Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1)
> or
> devices that implements only INTERFACE_CONVENTIONAL_PCI_DEVICE (is_express == 0)
> where not affected by the change.
>
> The only devices that were affected are those that are hybrid and also
> had (is_express == 1) - therefor only:
> - hw/vfio/pci.c
> - hw/usb/hcd-xhci.c
> - hw/xen/xen_pt.c
>
> For those 3 I made sure that QEMU_PCI_CAP_EXPRESS is on in instance_init()
>
> Signed-off-by: Yoni Bettan <ybettan@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2017-12-19 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 15:21 [Qemu-devel] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted Yoni Bettan
2017-12-18 15:25 ` Yoni Bettan
2017-12-19 8:15 ` Yoni Bettan
2017-12-19 16:42 ` Eduardo Habkost [this message]
2017-12-19 17:01 ` Marcel Apfelbaum
2018-01-16 4:47 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219164218.GB4836@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=dmitry@daynix.com \
--cc=hare@suse.com \
--cc=jasowang@redhat.com \
--cc=keith.busch@intel.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcel@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=paul.burton@mips.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=ybettan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).