* [Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address
@ 2017-12-19 8:28 Christian Borntraeger
2017-12-19 10:30 ` David Hildenbrand
2017-12-19 16:01 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Christian Borntraeger @ 2017-12-19 8:28 UTC (permalink / raw)
To: Cornelia Huck
Cc: qemu-devel, qemu-s390x, Halil Pasic, Alexander Graf, Thomas Huth,
David Hildenbrand, Richard Henderson, Jason J . Herne,
Christian Borntraeger
the highest cpu address is not the same as max_cpus. max_cpus
counts from 1 while the cpu address starts at 0.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
---
hw/s390x/sclp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
index 9be0cb80ad..21351ffffc 100644
--- a/hw/s390x/sclp.c
+++ b/hw/s390x/sclp.c
@@ -67,7 +67,7 @@ static void read_SCP_info(SCLPDevice *sclp, SCCB *sccb)
prepare_cpu_entries(sclp, read_info->entries, &cpu_count);
read_info->entries_cpu = cpu_to_be16(cpu_count);
read_info->offset_cpu = cpu_to_be16(offsetof(ReadInfo, entries));
- read_info->highest_cpu = cpu_to_be16(max_cpus);
+ read_info->highest_cpu = cpu_to_be16(max_cpus - 1);
read_info->ibc_val = cpu_to_be32(s390_get_ibc_val());
--
2.13.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address
2017-12-19 8:28 [Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address Christian Borntraeger
@ 2017-12-19 10:30 ` David Hildenbrand
2017-12-19 16:01 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2017-12-19 10:30 UTC (permalink / raw)
To: Christian Borntraeger, Cornelia Huck
Cc: qemu-devel, qemu-s390x, Halil Pasic, Alexander Graf, Thomas Huth,
Richard Henderson, Jason J . Herne
On 19.12.2017 09:28, Christian Borntraeger wrote:
> the highest cpu address is not the same as max_cpus. max_cpus
> counts from 1 while the cpu address starts at 0.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
> ---
> hw/s390x/sclp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> index 9be0cb80ad..21351ffffc 100644
> --- a/hw/s390x/sclp.c
> +++ b/hw/s390x/sclp.c
> @@ -67,7 +67,7 @@ static void read_SCP_info(SCLPDevice *sclp, SCCB *sccb)
> prepare_cpu_entries(sclp, read_info->entries, &cpu_count);
> read_info->entries_cpu = cpu_to_be16(cpu_count);
> read_info->offset_cpu = cpu_to_be16(offsetof(ReadInfo, entries));
> - read_info->highest_cpu = cpu_to_be16(max_cpus);
> + read_info->highest_cpu = cpu_to_be16(max_cpus - 1);
>
> read_info->ibc_val = cpu_to_be32(s390_get_ibc_val());
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address
2017-12-19 8:28 [Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address Christian Borntraeger
2017-12-19 10:30 ` David Hildenbrand
@ 2017-12-19 16:01 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2017-12-19 16:01 UTC (permalink / raw)
To: Christian Borntraeger
Cc: qemu-devel, qemu-s390x, Halil Pasic, Alexander Graf, Thomas Huth,
David Hildenbrand, Richard Henderson, Jason J . Herne
On Tue, 19 Dec 2017 09:28:07 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> the highest cpu address is not the same as max_cpus. max_cpus
s/the/The/
> counts from 1 while the cpu address starts at 0.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
> ---
> hw/s390x/sclp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> index 9be0cb80ad..21351ffffc 100644
> --- a/hw/s390x/sclp.c
> +++ b/hw/s390x/sclp.c
> @@ -67,7 +67,7 @@ static void read_SCP_info(SCLPDevice *sclp, SCCB *sccb)
> prepare_cpu_entries(sclp, read_info->entries, &cpu_count);
> read_info->entries_cpu = cpu_to_be16(cpu_count);
> read_info->offset_cpu = cpu_to_be16(offsetof(ReadInfo, entries));
> - read_info->highest_cpu = cpu_to_be16(max_cpus);
> + read_info->highest_cpu = cpu_to_be16(max_cpus - 1);
>
> read_info->ibc_val = cpu_to_be32(s390_get_ibc_val());
>
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-19 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-19 8:28 [Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address Christian Borntraeger
2017-12-19 10:30 ` David Hildenbrand
2017-12-19 16:01 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).