* [Qemu-devel] [PATCH] target/m68k: remove unused variable gen_throws_exception
@ 2017-12-20 13:08 Laurent Vivier
2017-12-20 13:17 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2017-12-20 16:06 ` [Qemu-devel] " Thomas Huth
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Vivier @ 2017-12-20 13:08 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Laurent Vivier
It has been introduced by e6e5906b6e ("ColdFire target."),
but the content is never used.
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
target/m68k/translate.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index b60909222c..dfb2d5dad2 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -181,11 +181,6 @@ static void do_writebacks(DisasContext *s)
#define IS_USER(s) s->user
#endif
-/* XXX: move that elsewhere */
-/* ??? Fix exceptions. */
-static void *gen_throws_exception;
-#define gen_last_qop NULL
-
typedef void (*disas_proc)(CPUM68KState *env, DisasContext *s, uint16_t insn);
#ifdef DEBUG_DISPATCH
@@ -310,7 +305,6 @@ static inline TCGv gen_load(DisasContext * s, int opsize, TCGv addr, int sign)
default:
g_assert_not_reached();
}
- gen_throws_exception = gen_last_qop;
return tmp;
}
@@ -331,7 +325,6 @@ static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
default:
g_assert_not_reached();
}
- gen_throws_exception = gen_last_qop;
}
typedef enum {
@@ -1001,7 +994,6 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
}
tcg_temp_free(tmp);
tcg_temp_free_i64(t64);
- gen_throws_exception = gen_last_qop;
}
static void gen_store_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
@@ -1056,7 +1048,6 @@ static void gen_store_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
}
tcg_temp_free(tmp);
tcg_temp_free_i64(t64);
- gen_throws_exception = gen_last_qop;
}
static void gen_ldst_fp(DisasContext *s, int opsize, TCGv addr,
@@ -5561,7 +5552,6 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)
gen_tb_start(tb);
do {
pc_offset = dc->pc - pc_start;
- gen_throws_exception = NULL;
tcg_gen_insn_start(dc->pc, dc->cc_op);
num_insns++;
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] target/m68k: remove unused variable gen_throws_exception
2017-12-20 13:08 [Qemu-devel] [PATCH] target/m68k: remove unused variable gen_throws_exception Laurent Vivier
@ 2017-12-20 13:17 ` Philippe Mathieu-Daudé
2017-12-20 16:06 ` [Qemu-devel] " Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-12-20 13:17 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-devel@nongnu.org Developers, QEMU Trivial
On Wed, Dec 20, 2017 at 10:08 AM, Laurent Vivier <laurent@vivier.eu> wrote:
> It has been introduced by e6e5906b6e ("ColdFire target."),
> but the content is never used.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/m68k/translate.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index b60909222c..dfb2d5dad2 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -181,11 +181,6 @@ static void do_writebacks(DisasContext *s)
> #define IS_USER(s) s->user
> #endif
>
> -/* XXX: move that elsewhere */
> -/* ??? Fix exceptions. */
> -static void *gen_throws_exception;
> -#define gen_last_qop NULL
> -
> typedef void (*disas_proc)(CPUM68KState *env, DisasContext *s, uint16_t insn);
>
> #ifdef DEBUG_DISPATCH
> @@ -310,7 +305,6 @@ static inline TCGv gen_load(DisasContext * s, int opsize, TCGv addr, int sign)
> default:
> g_assert_not_reached();
> }
> - gen_throws_exception = gen_last_qop;
> return tmp;
> }
>
> @@ -331,7 +325,6 @@ static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
> default:
> g_assert_not_reached();
> }
> - gen_throws_exception = gen_last_qop;
> }
>
> typedef enum {
> @@ -1001,7 +994,6 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
> }
> tcg_temp_free(tmp);
> tcg_temp_free_i64(t64);
> - gen_throws_exception = gen_last_qop;
> }
>
> static void gen_store_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
> @@ -1056,7 +1048,6 @@ static void gen_store_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
> }
> tcg_temp_free(tmp);
> tcg_temp_free_i64(t64);
> - gen_throws_exception = gen_last_qop;
> }
>
> static void gen_ldst_fp(DisasContext *s, int opsize, TCGv addr,
> @@ -5561,7 +5552,6 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)
> gen_tb_start(tb);
> do {
> pc_offset = dc->pc - pc_start;
> - gen_throws_exception = NULL;
> tcg_gen_insn_start(dc->pc, dc->cc_op);
> num_insns++;
>
> --
> 2.14.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target/m68k: remove unused variable gen_throws_exception
2017-12-20 13:08 [Qemu-devel] [PATCH] target/m68k: remove unused variable gen_throws_exception Laurent Vivier
2017-12-20 13:17 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
@ 2017-12-20 16:06 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2017-12-20 16:06 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial
On 20.12.2017 14:08, Laurent Vivier wrote:
> It has been introduced by e6e5906b6e ("ColdFire target."),
> but the content is never used.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target/m68k/translate.c | 10 ----------
> 1 file changed, 10 deletions(-)
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-20 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-20 13:08 [Qemu-devel] [PATCH] target/m68k: remove unused variable gen_throws_exception Laurent Vivier
2017-12-20 13:17 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2017-12-20 16:06 ` [Qemu-devel] " Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).