From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 03/14] iotests: fix 197 for vpc
Date: Wed, 20 Dec 2017 14:19:28 +0100 [thread overview]
Message-ID: <20171220131939.27543-4-kwolf@redhat.com> (raw)
In-Reply-To: <20171220131939.27543-1-kwolf@redhat.com>
From: John Snow <jsnow@redhat.com>
VPC has some difficulty creating geometries of particular size.
However, we can indeed force it to use a literal one, so let's
do that for the sake of test 197, which is testing some specific
offsets.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Lukáš Doktor <ldoktor@redhat.com>
---
tests/qemu-iotests/197 | 4 ++++
tests/qemu-iotests/common.filter | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/197 b/tests/qemu-iotests/197
index 887eb4f496..5e869fe2b7 100755
--- a/tests/qemu-iotests/197
+++ b/tests/qemu-iotests/197
@@ -60,6 +60,10 @@ echo '=== Copy-on-read ==='
echo
# Prep the images
+# VPC rounds image sizes to a specific geometry, force a specific size.
+if [ "$IMGFMT" = "vpc" ]; then
+ IMGOPTS=$(_optstr_add "$IMGOPTS" "force_size")
+fi
_make_test_img 4G
$QEMU_IO -c "write -P 55 3G 1k" "$TEST_IMG" | _filter_qemu_io
IMGPROTO=file IMGFMT=qcow2 IMGOPTS= TEST_IMG_FILE="$TEST_WRAP" \
diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
index d9237799e9..f08248bfd9 100644
--- a/tests/qemu-iotests/common.filter
+++ b/tests/qemu-iotests/common.filter
@@ -134,7 +134,8 @@ _filter_img_create()
-e "s# log_size=[0-9]\\+##g" \
-e "s# refcount_bits=[0-9]\\+##g" \
-e "s# key-secret=[a-zA-Z0-9]\\+##g" \
- -e "s# iter-time=[0-9]\\+##g"
+ -e "s# iter-time=[0-9]\\+##g" \
+ -e "s# force_size=\\(on\\|off\\)##g"
}
_filter_img_info()
--
2.13.6
next prev parent reply other threads:[~2017-12-20 13:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 13:19 [Qemu-devel] [PULL 00/14] Block layer patches Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 01/14] hw/block/nvme: Convert to realize Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 02/14] block: Formats don't need CONSISTENT_READ with NO_IO Kevin Wolf
2017-12-20 13:19 ` Kevin Wolf [this message]
2017-12-20 13:19 ` [Qemu-devel] [PULL 04/14] block: Make bdrv_drain_invoke() recursive Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 05/14] block: Call .drain_begin only once in bdrv_drain_all_begin() Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 06/14] test-bdrv-drain: Test BlockDriver callbacks for drain Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 07/14] block: bdrv_drain_recurse(): Remove unused begin parameter Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 08/14] block: Don't wait for requests in bdrv_drain*_end() Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 09/14] block: Unify order in drain functions Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 10/14] qemu-img: Document --force-share / -U Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 11/14] block: Don't acquire AioContext in hmp_qemu_io() Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 12/14] qcow2: get rid of qcow2_backing_read1 routine Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 13/14] block: Document that x-blockdev-change breaks quorum children list Kevin Wolf
2017-12-20 13:19 ` [Qemu-devel] [PULL 14/14] nvme: Add tracing Kevin Wolf
2017-12-20 15:30 ` [Qemu-devel] [PULL 00/14] Block layer patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220131939.27543-4-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).